381286 - Deleting <treechildren/> doesn't hide scrollbar

Status: NEW

(Core :: XUL, defect)

Description

[[e-mail]]

When you append a <treechildren/> to a tree then when the tree body frame ensures its view it updates the scrollbars. However when you remove the <treechildren> the tree body frame doesn't update the scrollbars. I've verified this with a custom view (thread pane), RDFliner and content view.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Neil Deakin]

Comment on attachment 265382 [details] [diff] [review]
Proposed patch

Looks OK, but is it s a good idea to fire events while in the frame's Destroy method?

Comment 3

[[e-mail]]

(In reply to comment #2)
>(From update of attachment 265382 [details] [diff] [review])
>Looks OK, but is it s a good idea to fire events while in the frame's Destroy method?
Probably not, but Smaug may know how to fire them asynchrously (note that GetMinSize could fire events, which may not be a good idea either).

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Could you upload a testcase?

Do you really need to fire any events in this case?
(Well, there is anyway DOMNodeRemoved.)
What happens usually when the child elements of an overflow:auto are removed?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Hmm, I guess underflow event is dispatched.

Comment 6

[Neil Deakin]

Comment on attachment 265382 [details] [diff] [review]
Proposed patch

You can fire events asynchronously by implementing nsIRunnable as in several places in the menu code.

Comment 7

[Jan Varga [:janv]]

The plan is to remove the XUL "tree" widget in future (bug 1446335), but this has a patch, so for now I'm not going to wontfix this.