381329 - Build fails with GCC-4.3 due to extra semi-colons and '-pedantic' flag

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Art Haas]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a5pre) Gecko/20070519 SeaMonkey/1.5a
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a5pre) Gecko/20070519 SeaMonkey/1.5a

Hi.

Building Firefox will fail with the development GCC-4.3 compiler due to extra semi-colons in the code and the '-pedantic' flag. 

Reproducible: Always

Steps to Reproduce:
1. Install GCC-4.3 snapshot.
2. Configure and build Firefox.
3. Start 'make' and let things rip.
Actual Results:  
Build fails.

Expected Results:  
Build succeeds.

I'll attach a patch which removes the extra semi-colons in three files.

Comment 1

[Art Haas]

Attachment: Patch removing extra semi-colons

Here's the fix.

Comment 2

[Art Haas]

Attachment: Patch removing extra semi-colon characters

Here's a better patch - in addition to fixing the three files I found problems with in my Firefox build, I did a SeaMonkey build with GCC-4.3 and removed the extra semi-colons from files used during the building of the mail/news client.

Comment 3

[Art Haas]

Should have also added that the patch adds a missing newline to nsRssService.cpp; the lack of a new-line also causes GCC-4.3 and '-pedantic' to error out when compiling this file.

Comment 4

[Samuel Sidler (old account; do not CC)]

Confirming and reassigning since this has an r/sr'd patch.

Comment 5

[Kenneth Herron]

" Patch removing extra semi-colon characters" checked in (with some trivial bitrot fixed). Clearing checkin-needed status.

Comment 6

[Matthew Gregan [:kinetik]]

Art's patch has been checked in and current trunk builds for me with GCC 4.3.  Resolving bug.