remove CSS rules pointing to inexistent classicBindings.xml

RESOLVED FIXED in mozilla1.9alpha5

Status

()

RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: kairo, Unassigned)

Tracking

Trunk
mozilla1.9alpha5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
formatting.css on *stripe and Classic refers to classicBindings.xml but that file doesn't even exist. We seems to not use the "double-box" that appears to be defined using that file anyways, so we just should remove those definitions.

See http://mxr.mozilla.org/mozilla/search?string=classicBindings.xml and http://mxr.mozilla.org/seamonkey/search?string=double-box

Comment 1

11 years ago
Created attachment 265462 [details] [diff] [review]
Remove obsolete style rules (only toolkit/themes part of patch checked in)

Heh, that stuff is pretty old - it doesn't even exist on the 1.7 branch. Not sure if it's worth changing Classic (it's already behind on mac), but I've included Classic in the patch (hence the sr request).
Assignee: nobody → stefanh
Status: NEW → ASSIGNED
Attachment #265462 - Flags: superreview?(neil)
Attachment #265462 - Flags: review?(neil)

Updated

11 years ago
Summary: remove CSS rules pinting to inexistent classicBindings.xml → remove CSS rules pointing to inexistent classicBindings.xml
Target Milestone: --- → mozilla1.9alpha5
(Reporter)

Comment 2

11 years ago
Comment on attachment 265462 [details] [diff] [review]
Remove obsolete style rules (only toolkit/themes part of patch checked in)

That's exactly the patch I would have done, so marking review as Neil still gets his word on sr ;-)
Attachment #265462 - Flags: review?(neil) → review+

Comment 3

11 years ago
Comment on attachment 265462 [details] [diff] [review]
Remove obsolete style rules (only toolkit/themes part of patch checked in)

I think I need toolkit review as well :-)
Attachment #265462 - Flags: review?(mano)
Comment on attachment 265462 [details] [diff] [review]
Remove obsolete style rules (only toolkit/themes part of patch checked in)

r=mano.
Attachment #265462 - Flags: review?(mano) → review+

Comment 5

11 years ago
Comment on attachment 265462 [details] [diff] [review]
Remove obsolete style rules (only toolkit/themes part of patch checked in)

Cancelling the sr request. I'll just checkin the *stripe part.
Attachment #265462 - Flags: superreview?(neil)

Comment 6

11 years ago
--> toolkit
Assignee: stefanh → nobody
Status: ASSIGNED → NEW
Component: Themes → XUL Widgets
Product: Core → Toolkit
QA Contact: themes → xul.widgets

Comment 7

11 years ago
Checking in toolkit/themes/pinstripe/global/formatting.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/formatting.css,v  <--  formatting.css
new revision: 1.6; previous revision: 1.5
done
Checking in toolkit/themes/winstripe/global/formatting.css;
/cvsroot/mozilla/toolkit/themes/winstripe/global/formatting.css,v  <--  formatting.css
new revision: 1.9; previous revision: 1.8
done
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Attachment #265462 - Attachment description: Remove obsolete style rules → Remove obsolete style rules (only toolkit/themes part of patch checked in)

Comment 8

11 years ago
Comment on attachment 265462 [details] [diff] [review]
Remove obsolete style rules (only toolkit/themes part of patch checked in)

This got delayed while I was catching up on bugmail but for the record you would have had r+sr=me.
You need to log in before you can comment on or make changes to this bug.