Closed
Bug 381369
Opened 17 years ago
Closed 17 years ago
Tweak Components.utils.import IDL comments
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha5
People
(Reporter: asqueella, Assigned: asqueella)
References
Details
Attachments
(1 file)
9.13 KB,
patch
|
sayrer
:
review+
|
Details | Diff | Splinter Review |
1. Mention the format of 'registryLocation' parameter (with a link to bug 380970), don't mention moduleURL anywhere 2. Make it clear how targetObj is handled. 3. Make it clear that the registryLocation->global obj hash uses the file, not the string 'registryLocation' as the hash key. 4. Fix JS pseudo-signatures in comments 5. Mention that the comments are duplicated across two interfaces so that they don't get out of sync.
Attachment #265457 -
Flags: review?(sayrer)
Comment 1•17 years ago
|
||
Comment on attachment 265457 [details] [diff] [review] patch looks good, thanks
Attachment #265457 -
Flags: review?(sayrer) → review+
Assignee | ||
Comment 2•17 years ago
|
||
mozilla/js/src/xpconnect/idl/xpcIJSModuleLoader.idl 1.3 mozilla/js/src/xpconnect/idl/xpccomponents.idl 1.31 mozilla/js/src/xpconnect/loader/mozJSComponentLoader.cpp 1.134 mozilla/js/src/xpconnect/src/xpccomponents.cpp 1.110
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•17 years ago
|
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9alpha5
You need to log in
before you can comment on or make changes to this bug.
Description
•