Sort order is not remembered by Bookmarks Manager when the View menu is used

VERIFIED FIXED in Firefox 3 alpha6

Status

()

Firefox
Bookmarks & History
VERIFIED FIXED
11 years ago
8 years ago

People

(Reporter: Ryuichi KUBUKI, Assigned: Christine Yen)

Tracking

Trunk
Firefox 3 alpha6
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.62 KB, patch
(not reading, please use seth@sspitzer.org instead)
: review+
Details | Diff | Splinter Review
(Reporter)

Description

11 years ago
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070521 Minefield/3.0a5pre ID:2007052103 [cairo]

1. Open Bookmarks Manager
2. View | Unsorted
3. Close Firefox and restart
4. Open Bookmarks Manager

Actual result:

The sort order is Sort by Title

Expected result:

The sort order is unsorted
I can't reproduce this with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070520 Minefield/3.0a5pre
Every time when I close the bookmarks manager and/or restart Firefox, it defaults to Unsorted. It appears to have no memory or own will, at least not here. :) 
I see the same as Ria, the setting always goes back to 'Unsorted'.  Setting any of the other options do not seem to retain the setting.  Not sure if the 'View' setting should persist, or if this is intended behavior.

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a5pre) Gecko/20070521 Minefield/3.0a5pre Firefox/3.0 ID:2007052104 [cairo]
(Reporter)

Comment 3

11 years ago
In my case I used it with Unsorted before Places. But after Places was enabled with the imported bookmark, it was changed to Sort By Title and my choice for the other order doesn't persist for another session.
(Reporter)

Comment 4

11 years ago
OK I found a workaround, the View menu in Bookmarks Manager doesn't work but sort done by clicking on the "Title" in the columns is remembered after restart.
Summary: Sort order is not rememberd by Bookmarks Manager → Sort order is not rememberd by Bookmarks Manager when the View menu is used
I can confirm what KL writes:  I return to "View | Sort By Title" (as that's what I did with the column headers) each time, even when I switch the "view | sort by" using the view menu.
Summary: Sort order is not rememberd by Bookmarks Manager when the View menu is used → Sort order is not remembered by Bookmarks Manager when the View menu is used
(Assignee)

Updated

11 years ago
Assignee: nobody → cyen
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

11 years ago
OS: Windows XP → All
(Assignee)

Comment 6

11 years ago
More notes -- sorting via the View menu and clicking the tree column headings actually calls different javascript functions in places.js:

in the view menu, oncommand="ViewMenu.setSortColumn(aColumnID, aDirection);"
http://mxr.mozilla.org/seamonkey/source/browser/components/places/content/places.xul#259

by clicking "Title" or "Location," etc... "OptionsFilter.update(this._content.getResult());" instead
http://mxr.mozilla.org/seamonkey/source/browser/components/places/content/places.js#237
(Assignee)

Comment 7

11 years ago
Created attachment 267766 [details] [diff] [review]
patch
Attachment #267766 - Flags: review?(sspitzer)
Comment on attachment 267766 [details] [diff] [review]
patch

r=sspitzer

I'll land this today, once the tree opens.
Attachment #267766 - Flags: review?(sspitzer) → review+
fixed.

Checking in places.js;
/cvsroot/mozilla/browser/components/places/content/places.js,v  <--  places.js
new revision: 1.88; previous revision: 1.87
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 alpha6
Blocks: 318810
Verified in Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/200707270404 Minefield/3.0a7pre.
Status: RESOLVED → VERIFIED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.