Closed Bug 381468 Opened 17 years ago Closed 16 years ago

Convert toolkit application/x-javascript to application/javascript

Categories

(Toolkit :: UI Widgets, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: sdwilsh, Assigned: sdwilsh)

References

()

Details

Attachments

(2 files, 1 obsolete file)

Once again, lack of a better component..

Switching over toolkit code from application/x-javascript to application/javascript
Attached patch v1.0 (obsolete) — Splinter Review
This gets everything (baring some of the files I touch with my download manager patch).  I fixed 80 character line wrapping where it was an issue too.
Assignee: nobody → sdwilsh
Status: NEW → ASSIGNED
Attachment #265551 - Flags: review?(gavin.sharp)
Fair question - the bug this blocks has a few more details, but basically people are still using appliation/x-javascript when we really aught to be using application/javascript (it's been approved!) simply because everywhere else uses it.  I'm just trying to clean up our code-base with this really.
Attached patch v1.1Splinter Review
Fixes comments on irc.
Attachment #265551 - Attachment is obsolete: true
Attachment #265563 - Flags: review?(gavin.sharp)
Attachment #265551 - Flags: review?(gavin.sharp)
Attachment #265563 - Flags: review?(gavin.sharp) → review+
Checking in toolkit/components/alerts/resources/content/alert.xul;
new revision: 1.9; previous revision: 1.8
Checking in toolkit/mozapps/downloads/content/unknownContentType.xul;
new revision: 1.21; previous revision: 1.20
Checking in toolkit/mozapps/downloads/content/downloadProperties.xul;
new revision: 1.6; previous revision: 1.5
Checking in toolkit/profile/content/createProfileWizard.xul;
new revision: 1.6; previous revision: 1.5
Checking in toolkit/profile/content/profileSelection.xul;
new revision: 1.9; previous revision: 1.8
Checking in toolkit/content/about.xhtml;
new revision: 1.23; previous revision: 1.22
Checking in toolkit/content/charsetOverlay.xul;
new revision: 1.7; previous revision: 1.6
Checking in toolkit/content/commonDialog.xul;
new revision: 1.11; previous revision: 1.10
Checking in toolkit/content/customizeCharset.xul;
new revision: 1.7; previous revision: 1.6
Checking in toolkit/content/customizeToolbar.xul;
new revision: 1.20; previous revision: 1.19
Checking in toolkit/content/editMenuOverlay.xul;
new revision: 1.6; previous revision: 1.5
Checking in toolkit/content/finddialog.xul;
new revision: 1.16; previous revision: 1.15
Checking in toolkit/content/macWindowMenu.inc;
new revision: 1.2; previous revision: 1.1
Checking in toolkit/content/plugins.html;
new revision: 1.2; previous revision: 1.1
Checking in toolkit/content/selectDialog.xul;
new revision: 1.3; previous revision: 1.2
Checking in toolkit/content/widgets/browser.xml;
new revision: 1.103; previous revision: 1.102
Checking in toolkit/content/widgets/editor.xml;
new revision: 1.8; previous revision: 1.7
Checking in toolkit/components/viewsource/content/viewPartialSource.xul;
new revision: 1.27; previous revision: 1.26
Checking in toolkit/components/viewsource/content/viewSource.xul;
new revision: 1.34; previous revision: 1.33
Checking in toolkit/components/filepicker/content/filepicker.xul;
new revision: 1.11; previous revision: 1.10
Checking in toolkit/components/help/content/help.xul;
new revision: 1.36; previous revision: 1.35
Checking in toolkit/components/printing/content/printPageSetup.xul;
new revision: 1.12; previous revision: 1.11
Checking in toolkit/components/printing/content/printPreviewProgress.xul;
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/components/printing/content/printProgress.xul;
new revision: 1.5; previous revision: 1.4
Checking in toolkit/components/printing/content/printdialog.xul;
new revision: 1.9; previous revision: 1.8
Checking in toolkit/components/printing/content/printjoboptions.xul;
new revision: 1.9; previous revision: 1.8
Checking in toolkit/components/console/content/console.xul;
new revision: 1.14; previous revision: 1.13
Checking in toolkit/components/cookie/content/cookieAcceptDialog.xul;
new revision: 1.11; previous revision: 1.10
Checking in toolkit/obsolete/content/dialogOverlay.xul;
new revision: 1.3; previous revision: 1.2
Checking in toolkit/obsolete/content/globalOverlay.xul;
new revision: 1.2; previous revision: 1.1
Checking in toolkit/mozapps/update/content/errors.xul;
new revision: 1.15; previous revision: 1.14
Checking in toolkit/mozapps/update/content/history.xul;
new revision: 1.6; previous revision: 1.5
Checking in toolkit/mozapps/update/content/incompatible.xul;
new revision: 1.7; previous revision: 1.6
Checking in toolkit/mozapps/update/content/updates.xul;
new revision: 1.33; previous revision: 1.32
Checking in toolkit/mozapps/plugins/content/pluginInstallerWizard.xul;
new revision: 1.10; previous revision: 1.9
Checking in toolkit/mozapps/extensions/content/about.xul;
new revision: 1.11; previous revision: 1.10
Checking in toolkit/mozapps/extensions/content/extensions.xul;
new revision: 1.55; previous revision: 1.54
Checking in toolkit/mozapps/extensions/content/list.xul;
new revision: 1.6; previous revision: 1.5
Checking in toolkit/mozapps/extensions/content/update.xul;
new revision: 1.18; previous revision: 1.17
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
I seem to have missed three files...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch v1.1+Splinter Review
They were fixed in my tree, I just forgot to grab them in the patch it seems.
Attachment #265834 - Flags: review?(gavin.sharp)
Attachment #265834 - Flags: review?(gavin.sharp) → review+
Checking in toolkit/mozapps/preferences/changemp.xul;
new revision: 1.4; previous revision: 1.3
Checking in toolkit/mozapps/preferences/ocsp.xul;
new revision: 1.7; previous revision: 1.6
Checking in toolkit/mozapps/preferences/removemp.xul;
new revision: 1.3; previous revision: 1.2
Status: REOPENED → RESOLVED
Closed: 17 years ago17 years ago
Resolution: --- → FIXED
3 missed or "regressed":
{{
/toolkit/content/commonDialog.xul
    * line 19 -- <script type="application/x-javascript" src="chrome://global/content/globalOverlay.js"/>
/toolkit/content/widgets/findbar.xml
    * line 923 -- aMimeType == "application/x-javascript" ||
/toolkit/components/viewconfig/content/configIntValue.xul
    * line 50 -- <script type="application/x-javascript">
}}
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to comment #9)
> 3 missed or "regressed":
New bug please
Status: REOPENED → RESOLVED
Closed: 17 years ago16 years ago
Resolution: --- → FIXED
(In reply to comment #10)
> New bug please

Although I don't see the point in this case,
I filed bug 422577.
Severity: normal → trivial
No longer blocks: 442577
Depends on: 442577
You need to log in before you can comment on or make changes to this bug.