Open Bug 381508 Opened 14 years ago Updated 13 years ago

XUL editable menulist shouldn't use document.commandDispatcher

Categories

(Core :: XUL, defect)

defect
Not set
normal

Tracking

()

Future

People

(Reporter: neil, Unassigned)

References

Details

Attachments

(2 files)

Basically this is the editable menulist version of bug 329394.

I actually ran into the problem trying to use Wallet
(in SeaMonkey, Tools -> Form Manager -> Edit Form Info);
it was exposed as a side-effect of a security fix.
Attached patch v1.0Splinter Review
r,sr neil for xpfe; r gavin for toolkit
Assignee: nobody → sdwilsh
Status: NEW → ASSIGNED
Attachment #265610 - Flags: superreview?(neil)
Attachment #265610 - Flags: review?(neil)
Attachment #265610 - Flags: review?(gavin.sharp)
Comment on attachment 265610 [details] [diff] [review]
v1.0

Neil is also a toolkit peer - my bad
Attachment #265610 - Flags: review?(gavin.sharp)
Comment on attachment 265610 [details] [diff] [review]
v1.0

A pity that that's not the only occurrence of  focusedElement :-( The other one isn't so easy to fix :-\
Attachment #265610 - Flags: superreview?(neil)
Attachment #265610 - Flags: superreview+
Attachment #265610 - Flags: review?(neil)
Attachment #265610 - Flags: review+
Tell me about it.  If it turns out to be an issue though, I am wiling to have a crack at it.
Checking in toolkit/content/widgets/menulist.xml;
new revision: 1.29; previous revision: 1.28
Checking in xpfe/global/resources/content/bindings/menulist.xml;
new revision: 1.44; previous revision: 1.43
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
(In reply to comment #4)
>Tell me about it.  If it turns out to be an issue though, I am willing to have a
>crack at it.
Well, the problem is most easily demonstrated in SeaMonkey. Tools -> Form Manager -> Edit Form Info and drop down one of the editable menulists. Fortunately the error doesn't cause much loss of function. Alternatively you (or I, if I get time) could probably adapt the test case in bug 329394.
So I take it that this didn't fix things, and the other one needs to be fixed as well?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached file testcase
There's a much bigger problem at hand here, and I'm not sure what's up.
Target Milestone: --- → Future
Assignee: comrade693+bmo → nobody
Status: REOPENED → NEW
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.