381508 - XUL editable menulist shouldn't use document.commandDispatcher

Status: NEW

(Core :: XUL, defect)

Description

[[e-mail]]

Basically this is the editable menulist version of bug 329394.

I actually ran into the problem trying to use Wallet
(in SeaMonkey, Tools -> Form Manager -> Edit Form Info);
it was exposed as a side-effect of a security fix.

Comment 1

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

r,sr neil for xpfe; r gavin for toolkit

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 265610 [details] [diff] [review]
v1.0

Neil is also a toolkit peer - my bad

Comment 3

[[e-mail]]

Comment on attachment 265610 [details] [diff] [review]
v1.0

A pity that that's not the only occurrence of  focusedElement :-( The other one isn't so easy to fix :-\

Comment 4

[Shawn Wilsher :sdwilsh]

Tell me about it.  If it turns out to be an issue though, I am wiling to have a crack at it.

Comment 5

[Shawn Wilsher :sdwilsh]

Checking in toolkit/content/widgets/menulist.xml;
new revision: 1.29; previous revision: 1.28
Checking in xpfe/global/resources/content/bindings/menulist.xml;
new revision: 1.44; previous revision: 1.43

Comment 6

[[e-mail]]

(In reply to comment #4)
>Tell me about it.  If it turns out to be an issue though, I am willing to have a
>crack at it.
Well, the problem is most easily demonstrated in SeaMonkey. Tools -> Form Manager -> Edit Form Info and drop down one of the editable menulists. Fortunately the error doesn't cause much loss of function. Alternatively you (or I, if I get time) could probably adapt the test case in bug 329394.

Comment 7

[Shawn Wilsher :sdwilsh]

So I take it that this didn't fix things, and the other one needs to be fixed as well?

Comment 8

[Shawn Wilsher :sdwilsh]

Attachment: testcase

Comment 9

[Shawn Wilsher :sdwilsh]

There's a much bigger problem at hand here, and I'm not sure what's up.