381555 - "Show only display name" does only work for personal address book

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

If you have several address books (eg. private, business) the activation of the pref "Show only display name for people in my address book" does only work for the first address book. If you insert someone from the second or further address book the whole email address is displayed.

We should search within all address books until we find the appropriate person.

Comment 1

[Boying Lu]

Herik, can you provide steps to reproduce the bug?  Thanks

Comment 2

[Pete Riley]

Steps to reproduce:

1) Enable the option in Thunderbird:  "Tools > Options > Advanced > Show only display name for people in my address book"

2) Open Thunderbird's address book.

3) Use "File > New > Address Book" to create a new address book.

4) Select the new address book and add a new person,
   e.g. Joe Blow with an email address of [e-mail]

5) Send an email from Joe to yourself.  You can either create a new Thunderbird identity to do this ("Tools > Account Settings > (YourAccountName) > Manage Identities") or send the email from some other program or webmail that allows you to change the FROM information.

6) Click on the "Get Mail" button.  Click on the email from Joe.  Look at the FROM header in the headers pane.

Actual result:
Thunderbird says "From: Joe Blow <[e-mail]>"

Expected result:
Thunderbird says "From: Joe Blow"

The TO/CC/BCC headers in the headers pane should work in the same way as the FROM header.  Thanks!

Comment 3

[Boying Lu]

(In reply to comment #2)
> Steps to reproduce:
> 
> 1) Enable the option in Thunderbird:  "Tools > Options > Advanced > Show only
> display name for people in my address book"
> 
> 2) Open Thunderbird's address book.
> 
> 3) Use "File > New > Address Book" to create a new address book.
> 
> 4) Select the new address book and add a new person,
>    e.g. Joe Blow with an email address of [e-mail]
> 
> 5) Send an email from Joe to yourself.  You can either create a new Thunderbird
> identity to do this ("Tools > Account Settings > (YourAccountName) > Manage
> Identities") or send the email from some other program or webmail that allows
> you to change the FROM information.
> 
> 6) Click on the "Get Mail" button.  Click on the email from Joe.  Look at the
> FROM header in the headers pane.
> 
> Actual result:
> Thunderbird says "From: Joe Blow <[e-mail]>"
> 
> Expected result:
> Thunderbird says "From: Joe Blow"
> 
> The TO/CC/BCC headers in the headers pane should work in the same way as the
> FROM header.  Thanks!
> 

Thanks a lot. The patch is almost ready. I need to make it also works for CC and  BCC and will post it soon.

Comment 4

[Boying Lu]

I posted a patch in bug 243631 which also fix this bug I think.

Comment 5

[Mark Banner (:standard8)]

Attachment: The fix

Makes this work across all address books that implement the cardForEmailAddress function.

Comment 6

[David :Bienvenu]

Comment on attachment 334241 [details] [diff] [review]
The fix

but the options UI is a bit misleading, since we now look in multiple address books, instead of just using the default personal address book.

Comment 7

[Mark Banner (:standard8)]

(In reply to comment #6)
> (From update of attachment 334241 [details] [diff] [review])
> but the options UI is a bit misleading, since we now look in multiple address
> books, instead of just using the default personal address book.
> 
Bug 448692 is currently planning on removing that UI. I'll add it to my list of blockers for bug 450724 and I'll track what happens.

Comment 8

[Mark Banner (:standard8)]

Patch checked in, changeset id 135:b6532caf76a6

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1a2pre) Gecko/20080819030054 Shredder/3.0b1pre ID:20080819030054

I checked against cards within the OS X address book and my personal address book. Both works as expected. Further I changed the email address within the OS X card and the full email is displayed. Looks fine. Thanks Mark.

Same question here. Something for Litmus or better to have as automated tests?

Comment 10

[Mark Banner (:standard8)]

(In reply to comment #9)
> Same question here. Something for Litmus or better to have as automated tests?

Same answer, we have no capability for automated tests on external interfaces. Additionally we have no UI tests at the moment.

Leave it as testsuite? though as we may want to implement a test when we do have chrome tests. 

Comment 11

[Wayne Mery (:wsmwk)]

This FIXED bug is flagged with in‑testsuite?   It would be great if assignee or someone else can clear the flag if a test is not appropriate.  And if appropriate, create a test and plus the flag to finish off the bug.

Comment 12

[Ludovic Hirlimann [:Usul]]

Added https://litmus.mozilla.org/show_test.cgi?id=9511 in BFT and FFT