Closed Bug 381611 Opened 12 years ago Closed 12 years ago
Client pull script to combine repos for mozilla2 (client
We're going to have to stitch some repositories together for mozilla2. I've written a script (client.py) that will do this. Currently I've tested on Linux. This patch also removes checkout support from client.mk which is totally non-useful.
Attachment #265688 - Flags: review?(ted.mielczarek)
It'd be nice if you could make client.py a module with a default action a'la if __name__ == '__main__': That way, the intelligence inside client.py wouldn't be boxed in, and one could call into it from other python code, say, buildbot.
Comment on attachment 265688 [details] [diff] [review] client.py >diff -r 6100d773079a client.mk >+# To build a tree, > # 1. cvs co mozilla/client.mk That's not actually correct now, is it? > # Print out any options loaded from mozconfig. > all build checkout clean depend distclean export libs install realclean:: You missed a 'checkout' here. >diff -r 6100d773079a client.py >+NSPR_dirs = ('nsprpub',) >+NSS_dirs = ('dbm', >+ 'security/nss', >+ 'security/coreconf', >+ 'security/dbm') Any reason these aren't all caps? The only other comment I have is that this takes away the ability to do |make -f client.mk| and wind up with a fresh trunk build. I think it'd be useful to just be able to run one command that updates your source and does a build. I'm ok if it doesn't handle an initial checkout, to simplify things, but update/build would be really useful. r=me on the rest.
Attachment #265688 - Flags: review?(ted.mielczarek) → review+
Fixed the caps issue and the nits. I didn't add back a "checkout" target which forwards to client.py, but I will file followup on it. Pushed to mozilla-central Axel, if you'd like to make this a module, feel free to do so: I can't quite see what module API you'd want to expose, so I didn't worry about it.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.