Closed
Bug 381645
Opened 17 years ago
Closed 17 years ago
Remove nsBoxFrame::GetContentOf
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sharparrow1, Assigned: sharparrow1)
Details
Attachments
(1 file, 1 obsolete file)
|
24.78 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
nsBoxFrame::GetContentOf always returns exactly the same thing as GetContent(); therefore, all calls to GetContentOf can be replaced with calls to GetContent(). The ifdef changes in nsBoxFrame are just ifdefing out a couple of otherwise unused helper functions.
Attachment #265719 -
Flags: review?(dbaron)
Comment on attachment 265719 [details] [diff] [review] Patch r=dbaron, but I think you should call the isEmpty variables in nsSliderFrame wasEmpty instead.
Attachment #265719 -
Flags: review?(dbaron) → review+
|
Assignee | |
Comment 2•17 years ago
|
||
Attachment #265719 -
Attachment is obsolete: true
Attachment #265740 -
Flags: superreview?(roc)
Comment on attachment 265740 [details] [diff] [review] Updated patch Presumably dbaron can sr this trivially...
Attachment #265740 -
Flags: superreview?(roc) → superreview?(dbaron)
Comment on attachment 265740 [details] [diff] [review] Updated patch r+sr=dbaron
Attachment #265740 -
Flags: superreview?(dbaron)
Attachment #265740 -
Flags: superreview+
Attachment #265740 -
Flags: review+
|
|
Assignee | |
Comment 5•17 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
|
||
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•