Closed
Bug 381646
Opened 17 years ago
Closed 17 years ago
Re-enable tests for download manager
Categories
(Toolkit :: Downloads API, defect)
Toolkit
Downloads API
Tracking
()
RESOLVED
FIXED
People
(Reporter: sdwilsh, Assigned: sdwilsh)
Details
Attachments
(2 files, 1 obsolete file)
12.63 KB,
patch
|
Details | Diff | Splinter Review | |
2.24 KB,
patch
|
sayrer
:
review+
|
Details | Diff | Splinter Review |
After much debugging, I've got the tests working once again for the download manager. We can now enable them with these changes. I'd like to leave the prints in there on the off chance that this doesn't fix it so we can still debug. If this cycles ok, I'll attach a patch to remove them.
Assignee | ||
Updated•17 years ago
|
Attachment #265720 -
Flags: review?(gavin.sharp)
Updated•17 years ago
|
Assignee: nobody → sdwilsh
Comment 1•17 years ago
|
||
Comment on attachment 265720 [details] [diff] [review] v1.0 these look okay to me. I'm assuming they pass.
Attachment #265720 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 2•17 years ago
|
||
Attachment #265720 -
Attachment is obsolete: true
Assignee | ||
Comment 3•17 years ago
|
||
Checking in toolkit/components/downloads/test/Makefile.in; new revision: 1.3; previous revision: 1.2 Checking in toolkit/components/downloads/test/unit/head_download_manager.js; initial revision: 1.1 Checking in toolkit/components/downloads/test/unit/test_download_manager.js; new revision: 1.9; previous revision: 1.8 Checking in toolkit/components/downloads/test/unit/test_download_manager_migration.js; new revision: 1.2; previous revision: 1.1 Not marking fixed until I see it cycle green.
Assignee | ||
Comment 4•17 years ago
|
||
Attachment #265875 -
Flags: review?(sayrer)
Comment 5•17 years ago
|
||
Comment on attachment 265875 [details] [diff] [review] v1.0 windows orange worth a try :/
Attachment #265875 -
Flags: review?(sayrer) → review+
Assignee | ||
Comment 6•17 years ago
|
||
Checking in toolkit/components/downloads/test/unit/test_download_manager.js; new revision: 1.10; previous revision: 1.9 Checking in toolkit/components/downloads/test/unit/test_download_manager_migration.js; new revision: 1.3; previous revision: 1.2
Assignee | ||
Comment 7•17 years ago
|
||
windows box just went green. yey!
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•