Closed
Bug 381669
Opened 18 years ago
Closed 18 years ago
Checkin for bug 370282 regresses bug 364510
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: jaas)
References
Details
(Keywords: regression)
Attachments
(2 files)
|
1.87 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
|
1.92 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
Flags: blocking1.9+
In theory this is what we need to do, but I can't see a bug on Mac OS X to begin with so I can't vouch for it. I don't see the bug this supposedly regresses and I don't see any other bugs either.
Comment on attachment 265761 [details] [diff] [review]
fix v1.0
looks good to me. Just factor out the call to PresContext() into its own local variable so we don't call it twice.
Attachment #265761 -
Flags: superreview+
Attachment #265761 -
Flags: review+
Like I said, I'm not comfortable checking this in until I know what it does. This doesn't seem to fix any bugs for me.
Boris - can you provide a test case?
|
Reporter | |
Comment 4•18 years ago
|
||
Not offhand, nor should I need to, frankly. The code without this patch is demonstrably wrong -- it's violating the nsIFrame API. This patch makes us not violate it. If there _are_ any problems that ensue (which I doubt), they need to be fixed elsewhere.
Attachment #265814 -
Flags: review?(roc)
Attachment #265814 -
Flags: superreview+
Attachment #265814 -
Flags: review?(roc)
Attachment #265814 -
Flags: review+
landed on trunk
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•