Closed Bug 381669 Opened 14 years ago Closed 14 years ago

Checkin for bug 370282 regresses bug 364510

Categories

(Core :: Layout, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: jaas)

References

Details

(Keywords: regression)

Attachments

(2 files)

See bug 370282 comment 24.
Flags: blocking1.9+
Attached patch fix v1.0Splinter Review
In theory this is what we need to do, but I can't see a bug on Mac OS X to begin with so I can't vouch for it. I don't see the bug this supposedly regresses and I don't see any other bugs either.
Comment on attachment 265761 [details] [diff] [review]
fix v1.0

looks good to me. Just factor out the call to PresContext() into its own local variable so we don't call it twice.
Attachment #265761 - Flags: superreview+
Attachment #265761 - Flags: review+
Like I said, I'm not comfortable checking this in until I know what it does. This doesn't seem to fix any bugs for me.

Boris - can you provide a test case?
Not offhand, nor should I need to, frankly.  The code without this patch is demonstrably wrong -- it's violating the nsIFrame API.  This patch makes us not violate it.  If there _are_ any problems that ensue (which I doubt), they need to be fixed elsewhere.
Attached patch fix v1.0.1Splinter Review
Attachment #265814 - Flags: review?(roc)
landed on trunk
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.