Closed Bug 38170 Opened 24 years ago Closed 24 years ago

File menu has two 'quits' on it, Help items repeated, etc.

Categories

(SeaMonkey :: UI Design, defect, P2)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: agracebush, Assigned: bugs)

References

Details

(Keywords: regression, Whiteboard: [dogfood+][M16Blocker])

Attachments

(1 file)

Linux builds 2000-05-04-08M16
Launch and select File menu
at bottom is two instances of quit
not xpmenus.
Assignee: pinkerton → don
Component: XP Toolkit/Widgets: Menus → XPApps
well, i cannot see this on winNT or linux since it keeps crashing too quickly
for me (bug 38136). but i do see it on the Mac. making this All platforms.
Keywords: regression
OS: Linux → All
Hardware: PC → All
Putting on nsbeta2 radar. Not dogfood if quit/exit works.  Working?
Keywords: nsbeta2
yep, both 'quits' work fine. :-)
It looks to me like the content of platformGlobalOverlay.xul is being appended 
twice. If I add a second menu item, under the quit item, in that file, the File 
menu ends up with:

  Quit
  foopy
  Quit
  foopy

This smells like a C++ problem with overlays. Hyatt? Waterson?
Assignee: don → hyatt
I am seeing this problem in the "Help" menu of the commercial build.
Uh, actually globalOverlay.xul was added to navigator.xul last night,
but navigatorOverlay.xul already was overlaying globalOverlay.xul, so 
this pulls in platformGlobalOverlay.xul twice (no?).
mmm
Assignee: hyatt → ben
updated summary.
Summary: File menu has two 'quits' on it → File menu has two 'quits' on it, Help items repeated
OK, that's a keeper.  M16 for this for sure ...
Priority: P3 → P2
Target Milestone: --- → M16
*** Bug 38503 has been marked as a duplicate of this bug. ***
Putting on [nsbeta2+] radar.
Whiteboard: [nsbeta2+]
there's also a duplicate entry for Instant Message under File > New.
Summary: File menu has two 'quits' on it, Help items repeated → File menu has two 'quits' on it, Help items repeated, etc.
*** Bug 39056 has been marked as a duplicate of this bug. ***
Message compose has two quit menu items, it's due to the fact that we include 
twice globaloverlay.xul, once direclty (messengercompose.xul) and once 
indirectly through editoroverlay.xul
So, do we need an "include guard" for overlays? Or can you sort this out by not 
requiring the global overlay to be included twice?
*** Bug 39817 has been marked as a duplicate of this bug. ***
Two menu items. This bug is a duplicate. I get it. Ha Ha.
*** Bug 40182 has been marked as a duplicate of this bug. ***
*** Bug 40271 has been marked as a duplicate of this bug. ***
Mac Mozilla has two Quit items `normally', but only one when all windows are 
closed.

Waterson -- If the same overlay is being included twice, that feels like 
something wrong with the chrome, not something that should be worked around by 
implementing an include guard. In a hypothetical piece of chrome there might be a 
good reason for including an overlay twice, especially if it was a fairly simple 
one.
*** Bug 40307 has been marked as a duplicate of this bug. ***
I have a fix for the browser part of this bug,
stealing from ben.  Mail people, got a patch for me?
Assignee: ben → mcafee
Putting on [dogfood+]...need this fixed for M16.
Whiteboard: [nsbeta2+] → [dogfood+]
Keywords: patch
Whiteboard: [dogfood+] → [dogfood+] fix in hand
Fixed both the browser & mailcompose problems.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
verif 2000.05.24.08 [opt comm] on linux, mac and winnt.
Status: RESOLVED → VERIFIED
it's back again: Quit appears twice in the File menu. reopening. using today's
commercial bits, 2000.06.05.08.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
fwiw: The previous buld - 060420 - has another quirk to it:
Above the ONE quit item is a separator, and above that again an empty field with
an arrow outside. No submenu appears when selecting the empty field.
I see the duplicate "quits" multiple times on Aim standalone also. 
(Today it appeared 3 times in Aim standalone File menu).
yes, I see this too.  Assigned.
Status: REOPENED → ASSIGNED
no fix in hand, clearing status whiteboard
ben's recent XUL re-arranging caused this problem,
he's looking at this now, fix probably coming soon.
over to ben
Assignee: mcafee → ben
Status: ASSIGNED → NEW
Whiteboard: [dogfood+] fix in hand → [dogfood+]
so far I've found that TextEditorAppShell.xul includes both globalOverlay.xul
and editorOverlay.xul, editorOverlay.xul already includes globalOverlay.xul.
Probably some global (ha ha) double-inclusion going on.
fixed. 
Status: NEW → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → FIXED
verif all/all using opt comm bits, 2000.06.07.xx.
Status: RESOLVED → VERIFIED
this bug is back again - it was gone on this morning's build - and is showing up
again in the 2000060713 build.
reopening...still a problem in 6/9 mozilla branch build.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
To be clear: This exists in the candidate M16 branch builds. It does not exist 
in the M17 trunk builds. 

This is a trivial, zero-risk fix; one-line of XUL removed; it cannot break
the build -- see ben's checkin to trunk - 06/05/2000 18:15
Putting on [M16Blocker] for hopeful fix to branch.
Whiteboard: [dogfood+] → [dogfood+][M16Blocker]
Ben sez he will check in his trunk fix to the branch sometime tonight.
This is still not fixed in the M16 commercial builds.
Sigh.  OK, I'll find out what's going on ...
fixed now. (just checked in to Seamonkey_M16_BRANCH)
Status: REOPENED → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → FIXED
looks fine using today's commercial trunk bits, 2000.06.14.08-m17, all/all.
Status: RESOLVED → VERIFIED
Jus for the record..I still see two quits in AIM under the File menus for 
Compose session windows, and Chat session windows..but a separate bug was logged 
in Bugscape for it per Alex M.
http://Bugscape.netscape.com/show_bug.cgi?id=1191
Blocks: 41970
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: