381735 - reenable antialiased border drawing on Linux

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Bug 380473 disabled antialiased border drawing on Linux due to performance problems doing the PushGroup/PopGroup.  We should not ship a final release with this difference in platform parity, so we should either fix the performance problems and reenable it on Linux, or disable it cross-platform.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

We need to reevaluate this once my new patch lands for bug 368247 -- I'm pretty sure that there should be no performance difference with or without antialiasing with 1px borders.

Comment 2

[Michael Ventnor]

I can confirm that Linux border antialiasing no longer shows performance problems. Then again, I caught a build with Cairo 1.4.10, you should get rid of the disabling code when you reland 1.4.10.

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

I'm sure you don't need my help here. However, bug 368247 has been fixed long ago and I think this one should target beta 1. And maybe it does save you a couple of seconds ;)

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 283827 [details] [diff] [review]
patch

I tested it, which is probably all that's needed, although you might want to check with vlad.  r+sr=dbaron

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 283827 [details] [diff] [review]
patch

Yeah, sounds good to me..

Comment 6

[Reed Loden [:reed]]

Comment on attachment 283827 [details] [diff] [review]
patch

No approval needed, as this bug is blocking1.9+ and we're in threat level yellow.

Comment 7

[Reed Loden [:reed]]

(In reply to comment #6)
> ... and we're in threat level yellow.

s/yellow/orange/

Comment 8

[Reed Loden [:reed]]

Checking in layout/base/nsCSSRendering.cpp;
/cvsroot/mozilla/layout/base/nsCSSRendering.cpp,v  <--  nsCSSRendering.cpp
new revision: 3.327; previous revision: 3.326
done