381749 - unable to dnd folders within in the bookmarks sidebar / bookmark organizer dialog

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

unable to dnd folder in the bookmarks sidebar / bookmark organizer dialog.

I'm able to drag and drop folders, but nothing happens.

I don't see this on my recent windows trunk build, but I do on my recent mac builds.  (my builds are from around 5/22, so I'm updating and rebuilding now.)

Comment 1

[Tracy Walker [:tracy]]

Confirmed, dnd of folders in sidebar, organizer and toolbar is not working on Mac (5/23) but does work on Win XP (5/22)  Though I'm seeing some bugginess with dnd in the toolbar on Windows (I'll file another bug on it)

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

D&D works now within the bookmarks sidebar but not inside the Library (bug 405198). But sometimes the bookmark/folder isn't placed at the point where I dropped it. Instead it is jumping around and I get an assertion when expanding a folder:

ASSERT: Visible index is out of sync!
Stack Trace: 
0:PTV__refreshVisibleSection([xpconnect wrapped (nsISupports, nsINavHistoryResultNode, nsINavHistoryContainerResultNode)])
1:PTV_invalidateContainer([xpconnect wrapped (nsISupports, nsINavHistoryResultNode, nsINavHistoryContainerResultNode)])
2:PTV_containerClosed([xpconnect wrapped (nsISupports, nsINavHistoryResultNode, nsINavHistoryContainerResultNode)])
3:containerOpen(false)
4:PTV_toggleOpenState(7)
5:toggleOpenState(7)
6:changeOpenState(7)
7:onxblclick([object MouseEvent])

How should we proceed? Marking this bug as WFM? I could file my issue to a new bug with a detailed description.

Comment 3

[Marco Bonardo [:mak]]

Henrik, is this WFM now?

Comment 4

[Mukunda]

I'm having this problem on Linux with FF3 Beta 3

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Yes, seems to be fixed now. I'm not able to see this with the latest nightly build Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008022804 Minefield/3.0b4pre ID:2008022804

Mukunda, please run a test with a nightly build past beta3 because the possible fixes were done afterwards. If it is working we could close this bug as WFM.

Comment 6

[Marco Bonardo [:mak]]

on Linux i know for sure that folder dragging is not working on the toolbar

Comment 7

[Mukunda]

(In reply to comment #6)
> on Linux i know for sure that folder dragging is not working on the toolbar

And I just confirmed this with the latest trunk build. Unable to drag folders on the bookmarks toolbar, however, dragging other items works.

Comment 8

[Mukunda]

(In reply to comment #5)
> Yes, seems to be fixed now. I'm not able to see this with the latest nightly
> build Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre)
> Gecko/2008022804 Minefield/3.0b4pre ID:2008022804
> 
> Mukunda, please run a test with a nightly build past beta3 because the possible
> fixes were done afterwards. If it is working we could close this bug as WFM.
> 

Ok dragging works on linux with the latest on linux: 

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b4pre) Gecko/2008022804 Minefield/3.0b4pre

However, it's still not working perfectly - the browser locked up completely after doing a few simple drag/drop operations in the bookmark organizer window.

Comment 9

[Marco Bonardo [:mak]]

everything should be working now, use shift+drag to drag folders on the toolbar.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20081219 Minefield/3.2a1pre

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv