Closed Bug 381751 Opened 17 years ago Closed 17 years ago

when I drop a bookmark or link in the sidebar or bookmark manager dialog, it frequently doesn't go where I expect it to go

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3 alpha6

People

(Reporter: moco, Assigned: christineyen+bugs)

References

Details

when I drop a bookmark or link in the sidebar or bookmark manager dialog, it frequently doesn't go where I expect it to go.

when I drop, I have seen:

1) the bookmark will go one position higher than expected
2) if within the original folder, the bookmark not move at all
3) if I attempt to drop an item from folder a to folder b (and folder b is open), and drop it before the first item of folder b, it puts it at the end of folder b.

sorry that this bug is fuzzy, I'll clean it up and log separate bugs with better steps to reproduce.

it might that all of these are related to how we compute the insertion index.
I would like to fix this ASAP, A6 (or earlier).
Assignee: nobody → sspitzer
Flags: blocking-firefox3?
Target Milestone: --- → Firefox 3 alpha6
from bug 381441:

> 
> D&D inside 1 folder
> 1. You can't drag a bookmark to the lowest place anymore
> 2. You can drag a bookmark from top to bottom, but it needs to be 3 places
> down to get it appear 2 places down.
> 3  You can drag from bottom to top, but it ends up above where you draggged it
> to.
> 
> nb: we seem to be calculating the wrong position in both directions
> 
bug 382679 may be a dup
Assignee: sspitzer → nobody
Assignee: nobody → sspitzer
I noticed that multiple rss feeds being present caused this problem to be very obvious in a recent nightly.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070607 Minefield/3.0a6pre ID:2007060716 [cairo]
Assignee: sspitzer → cyen
Status: NEW → ASSIGNED
Flags: blocking-firefox3? → blocking-firefox3+
(In reply to comment #5)
> bug 382679 may be a dup
> 

Bug #382679 is a subset of the issues brought up in this bug, and should be mostly resolved. Only original issue #3 is still a problem half the time -- it depends on whether the mouse cursor is hovering slightly above the folder row or slightly above the item row, a difference of a couple pixels.
(In reply to comment #7)
> *** Bug 383824 has been marked as a duplicate of this bug. ***
> 

Bug 383824 isn't quite a dup of this bug, but shares the same issue of mouse cursor position vs. the drop indicator causing odd behavior
Testing single DnD scenarios:

Drag from one position to another within the root folder
Drag a bookmark one position up
Drag a bookmark one position down
Drag a bookmark two positions up
Drag a bookmark two positions down
Drag multiple bookmarks -- broken in mac, linux, see bug #336214

Drag from one position to the bottom within the root folder
Drag from the bottom to some position within the root folder

Drag from one position to another within a subfolder
Drag from one position to the bottom of a subfolder*
Drag from the bottom of a subfolder to some position
Drag from one position to the top of a subfolder*
Drag from the top of a subfolder to some position

Drag from the root folder to the middle of a subfolder
Drag from the root folder to the top of a subfolder*
Drag from the root folder to the bottom of a subfolder*

Drag from subfolder A to subfolder B (any)
Drag from the top of subfolder A to the bottom of subfolder B*
Drag from the bottom of subfolder A to the top of subfolder B*

* = "depends on location of the cursor... meaning, if the mouse cursor points a pixel or two above the drop indicator, there's a different behavior than if the mouse cursor points a pixel or two below the drop indicator. This is the difference that causes the "sporadic" popping-out-of-folder bug seen here.
Depends on: 382679
Depends on: 385970
with her fixes for bug #382679 and bug #385970, things are working as expected for me now, so marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre)
Gecko/2007072505 Minefield/3.0a7pre
 
Status: RESOLVED → VERIFIED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.