381770 - Should be able to undo changes in bookmarks from browser window (not only in Library)

Status: NEW

(Firefox :: Bookmarks & History, enhancement, P3)

Description

[Tracy Walker [:tracy]]

Seen on Windows and Mac trunk builds from 05/22. This is in parity with
2.0.0.3

-delete a bookmark (or folder) from the bookmarks toolbar
-attempt to *undo* with Edit -> Undo

tested results: undo is greyed out; can't undo deletion

expected results:  Undo is Black and able to undo the item deletion to recover it.

Comment 1

[Martijn Wargers (dead)]

This is now worksforme, using a 2007-06-07 build. However, "redo" is still greyed out after "undo".

Comment 2

[Tracy Walker [:tracy]]

Still(or re)broken with latest nighties on Mac and Windows XP

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

I can't use "Undo" from the Edit menu on the main browser window (in either Fx2 or nightlies) but can use it from the Bookmark Manager (in both versions) to undo the delete.

Not a blocker, but not sure that it's a regression, either.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

(feel free to renom if I've misunderstood!)

Comment 5

[Tracy Walker [:tracy]]

Not a regression; it never worked.  I think it should work from main menu though. It's a little hassle to have to open the Library to undo this deletion.  Not sure folk will intuitively know to do that in this case. Anyway, changing to enhancement request. 

Martign's comment confused me a bit.  I'll bet he was looking at the Organizer.

Comment 6

[Tracy Walker [:tracy]]

What is the Edit menu for if not for this sort of functionality.  If undo/redo of edit type actions made at the toolbar can be manipulated via Library > Organize, why can't it work correctly in the more familiar Main Menu Edit menu?

Comment 9

[Nicolas Turcot (:nico@nc)]

This problem also affects the Bookmarks menu.

An "undo" option in the Bookmark Toolbar/Menu would be imo the most intuitive solution.

Another possibility would be to prompt the user when he tries to delete a bookmark from the toolbar/menu (as suggested a long time ago for Seamonkey in bug 54813).

Comment 10

[Marco Bonardo [:mak]]

(In reply to comment #9)
> Another possibility would be to prompt the user when he tries to delete a
> bookmark from the toolbar/menu (as suggested a long time ago for Seamonkey in
> bug 54813).

nagging users with dialogs is not much useful, after some time they'll probably mark the "don't ask me again" checkbox, and  back to previous situation.

Uplifting undo to global browser looks the best solution, merged with current undo or with a new item in the bookmarks menu (i guess this could also be done by an add-on).
Or we could fire a notification (like downloads ones) saying "Bookmarks removed, you can undo this change in the Library" if the Library window is closed.
But definately, modal dialogs are not the best solution imo.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The undo step works if the bookmark has been deleted via the bookmarks sidebar. So we somehow fail in adding the transaction?

Comment 12

[Marco Bonardo [:mak]]

(In reply to comment #11)
> The undo step works if the bookmark has been deleted via the bookmarks sidebar.

This surprises me a lot, i thought the main undo had no support at all in Places code. Apart that, when i undo in the sidebar with the above method the bookmark is restored in the wrong position, while it works correctly in Library.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

For me the position is correct after the undo step.

Comment 15

[Johnathan Nightingale [:johnath]]

Still doesn't block.

Comment 16

[Marco Bonardo [:mak]]

this should be for any bookmark change made by the user, sidebar, toolbar, menu. As it is it's not well exposed, especially if the user doesn't commonly use the Library.

Comment 18

[Mark Banner (:standard8)]

Note: there's a prototype test for this in bug 1442157.

Comment 20

[Alin Ilea, Desktop QA]

Hi,
I am able to reproduce the issue in Release 93, Beta 94.0b1 and latest Nightly 95.0a1 (2021-10-05) using Win10. I'll set the flags accordingly.

Comment 21

[Mark Banner (:standard8)]

(In reply to Alin Ilea from comment #20)

I am able to reproduce the issue in Release 93, Beta 94.0b1 and latest Nightly 95.0a1 (2021-10-05) using Win10. I'll set the flags accordingly.

Please do not set tracking flags for years old issues, they create unnecessary noise for developers.

Comment 22

[BugBot [:suhaib / :marco/ :calixte]]

In the process of migrating remaining bugs to the new severity system, the severity for this bug cannot be automatically determined. Please retriage this bug using the new severity system.

Comment 23

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit BugBot documentation.