38179 - Class names with underscore should not be allowed

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Masatoshi Kimura [:emk]]

Steps to reproduce:
1. Launch Mozilla.
2. Navigate to the following attachment.

Actual behavior:
Both paragraphs will be red.

Expected behavior:
First paragraph should be black per spec.

( http://www.w3.org/TR/REC-CSS2/syndata.html#q4 )
|The following rules always hold:
(snip)
|*In CSS2, identifiers (including element names, classes, and IDs in selectors) 
|can contain only the characters [A-Za-z0-9] and ISO 10646 characters 161 and 
|higher, plus the hyphen (-);

This doesn't include undescore.

Nav4 also doesn't recognize class names with underscore.

Fixing this is very easy. Simply back the changes to nsCSSScanner.cpp in Jun 22 
1999 (See the above URL).

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Testcase

Comment 2

[Pierre Saslawsky]

Another excellent bug (with a fix!) from [e-mail].

Reassigned to Marc, like bug 38038.

Comment 3

[Marc Attinasi]

Very strange... Why would Peter specifically add code to support underscores in 
identifiers when the spec is so clear on their illegality?

Anyway, thanks VYV03354 (is that your real name?) for finding this and for 
proposing the fix. I'll apply it today.

Comment 4

[Marc Attinasi]

Fix applied. Thanks once again [e-mail]!

Comment 5

[Masatoshi Kimura [:emk]]

Verified fixed using 2000050513 nightly build on Windows 2000.
Marc: please call me emk. My ISP doesn't allow the name address :-(