The accesskey for "More" button in Page Info does not work

VERIFIED FIXED in Firefox 3 alpha6

Status

()

Firefox
Page Info Window
--
trivial
VERIFIED FIXED
11 years ago
10 years ago

People

(Reporter: Away for a while, Assigned: Away for a while)

Tracking

Trunk
Firefox 3 alpha6
Points:
---
Bug Flags:
blocking-firefox3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070524 Minefield/3.0a5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070524 Minefield/3.0a5pre

The access key (M) from the "More" button in Page Info (which switches to the Security section) gets overriden by the access key for the Media section, and cannot be used.

Reproducible: Always

Steps to Reproduce:
1. Load a page, and open the Page Info dialog.
2. See the "More" button with access key M.
3. Press Alt+M (or equivalent) on the keyboard.
Actual Results:  
The Page Info dialog switches to the Media section.

Expected Results:  
The Page Info dialog should switch to the Security section.

about:buildconfig

Build platform
target
i686-pc-cygwin

Build tools
Compiler 	Version 	Compiler flags
$(CYGWIN_WRAPPER) cl 	14.00.50727 	-TC -nologo -W3 -Gy -Fd$(PDBFILE)
$(CYGWIN_WRAPPER) cl 	14.00.50727 	-GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -Fd$(PDBFILE) -I/usr/X11R6/include

Configure arguments
--enable-application=browser --enable-application=browser --disable-debug --enable-optimize --enable-canvas --enable-svg --enable-xpctools --disable-tests --enable-places --enable-places-bookmarks --enable-storage --enable-safe-browsing --enable-url-classifier --enable-strip --disable-javaxpcom
(Assignee)

Comment 1

11 years ago
This is trivial enough to be targetted for FF3.a5, I think.
Flags: blocking-firefox3?
Target Milestone: --- → Firefox 3 alpha5
Version: unspecified → Trunk

Comment 2

11 years ago
The Target Milestone field is usually reserved for developers working on the bug.
Target Milestone: Firefox 3 alpha5 → ---
(Assignee)

Comment 3

11 years ago
Taking this over.  Posting a patch shortly.
Status: NEW → ASSIGNED
(Assignee)

Updated

11 years ago
Assignee: nobody → ehsan.akhgari
Status: ASSIGNED → NEW
(Assignee)

Comment 4

11 years ago
Created attachment 266046 [details] [diff] [review]
Patch to fix the access key

Fix for the accesskey by changing it to "o".
Attachment #266046 - Flags: review?
(Assignee)

Updated

11 years ago
Attachment #266046 - Flags: ui-review?(beltzner)
Attachment #266046 - Flags: review?(mano)
Attachment #266046 - Flags: review?
Flags: blocking-firefox3? → blocking-firefox3+
Comment on attachment 266046 [details] [diff] [review]
Patch to fix the access key

r=mano
Attachment #266046 - Flags: review?(mano) → review+

Updated

11 years ago
Target Milestone: --- → Firefox 3 alpha6
Comment on attachment 266046 [details] [diff] [review]
Patch to fix the access key

This doesn't need ui-review.
Attachment #266046 - Flags: ui-review?(beltzner)
Whiteboard: [checkin needed]
fix checked in.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
(Assignee)

Updated

11 years ago
Keywords: qawanted

Comment 8

11 years ago
On Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a6pre) Gecko/20070627 Minefield/3.0a6pre, it works when I press Alt-o (which I probably wouldn't have guessed if I were just using it), or when I move focus to the button (where the accesskey wouldn't be of much use).

Comment 9

11 years ago
According to comment #0, the bug is fixed, though.
(Assignee)

Updated

11 years ago
Keywords: qawanted → verifyme

Comment 10

11 years ago
The patch being OS-independent, and the reporter/patch author being on Windows, verifying.
Status: RESOLVED → VERIFIED
Keywords: verifyme

Comment 11

11 years ago
Verified on Mac as well.
You need to log in before you can comment on or make changes to this bug.