381858 - The accesskey for "More" button in Page Info does not work

Status: VERIFIED FIXED

(Firefox :: Page Info Window, defect)

Description

[(no longer active)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070524 Minefield/3.0a5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070524 Minefield/3.0a5pre

The access key (M) from the "More" button in Page Info (which switches to the Security section) gets overriden by the access key for the Media section, and cannot be used.

Reproducible: Always

Steps to Reproduce:
1. Load a page, and open the Page Info dialog.
2. See the "More" button with access key M.
3. Press Alt+M (or equivalent) on the keyboard.
Actual Results:  
The Page Info dialog switches to the Media section.

Expected Results:  
The Page Info dialog should switch to the Security section.

about:buildconfig

Build platform
target
i686-pc-cygwin

Build tools
Compiler 	Version 	Compiler flags
$(CYGWIN_WRAPPER) cl 	14.00.50727 	-TC -nologo -W3 -Gy -Fd$(PDBFILE)
$(CYGWIN_WRAPPER) cl 	14.00.50727 	-GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -Fd$(PDBFILE) -I/usr/X11R6/include

Configure arguments
--enable-application=browser --enable-application=browser --disable-debug --enable-optimize --enable-canvas --enable-svg --enable-xpctools --disable-tests --enable-places --enable-places-bookmarks --enable-storage --enable-safe-browsing --enable-url-classifier --enable-strip --disable-javaxpcom

Comment 1

[(no longer active)]

This is trivial enough to be targetted for FF3.a5, I think.

Comment 2

[Adam Guthrie]

The Target Milestone field is usually reserved for developers working on the bug.

Comment 3

[(no longer active)]

Taking this over.  Posting a patch shortly.

Comment 4

[(no longer active)]

Attachment: Patch to fix the access key

Fix for the accesskey by changing it to "o".

Comment 5

[Asaf Romano (gone)]

Comment on attachment 266046 [details] [diff] [review]
Patch to fix the access key

r=mano

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 266046 [details] [diff] [review]
Patch to fix the access key

This doesn't need ui-review.

Comment 7

[Daniel Brooks [:db48x]]

fix checked in.

Comment 8

[[:Aleksej]]

On Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a6pre) Gecko/20070627 Minefield/3.0a6pre, it works when I press Alt-o (which I probably wouldn't have guessed if I were just using it), or when I move focus to the button (where the accesskey wouldn't be of much use).

Comment 9

[[:Aleksej]]

According to comment #0, the bug is fixed, though.

Comment 10

[[:Aleksej]]

The patch being OS-independent, and the reporter/patch author being on Windows, verifying.

Comment 11

[Chris Cooper [:coop] (he/him)]

Verified on Mac as well.