381927 - end times in download manager properties are wrong or missing

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070524 Minefield/3.0a5pre ID:2007052407 [cairo]

repro:
start FF
download something
rightclick and select properties

result:
During download both the start and end time are displayed and the same.
after download only the starttime is shown

Comment 1

[Shawn Wilsher :sdwilsh]

End time doesn't get set until it finishes, so that kinda makes sense.  It really shouldn't be displayed during the download.  As for it not showing up in the end, yeah...that's a problem.

Comment 2

[Peter van der Woude [:Peter6]]

before the download is finished:

the start time is set when you click on the link to download
the end time is set when you hit [OK] in the save as dialog

( tested on http://hourly-archive.localgho.st/ )

Comment 3

[Shawn Wilsher :sdwilsh]

Er right, that makes sense with the code now that I've looked again.  I just can't seem to figure out what makes them hidden (what I see that makes them hidden doesn't make sense as to why it'd do it like it does now).

Comment 4

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

I was doing something stupid before, but didn't realize it because the code was really difficult to read.  I cleaned it up a bit in the process of fixing this bug.

This code cannot land until Bug 382839 lands.

Comment 6

[Asaf Romano (gone)]

Comment on attachment 267500 [details] [diff] [review]
v1.0

r=mano.

Comment 7

[Shawn Wilsher :sdwilsh]

Checking in toolkit/mozapps/downloads/content/downloadProperties.js;
new revision: 1.6; previous revision: 1.5

Comment 8

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070613 Minefield/3.0a6pre ID:2007061304 [cairo]

VERIFIED