Closed
Bug 381944
Opened 17 years ago
Closed 17 years ago
Fix all.js for OS2 and BeOS
Categories
(Core :: Preferences: Backend, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mozilla, Assigned: mozilla)
Details
Attachments
(1 file)
|
1.60 KB,
patch
|
mkaply
:
review+
|
Details | Diff | Splinter Review |
modules\libpref\src\init\all.js contains several #ifdefs for the different platforms but for OS/2 and BeOS it's just an #if. And in my latest trunk builds it seems that this is why the font prefs don't end up in greprefs\all.js. (They do on the branch, so I guess something has changed with the preprocessor that broke this.) Weird how 3 years old typos come back haunting midnight development. ;-) Anyway, the patch should fix the problem. It also adds a font.alias-list line that will be needed on OS/2 for ongoing Thebes work (e.g. for bug 366664 and bug 381333).
Attachment #266006 -
Flags: review?(cbiesinger)
|
||
Comment 1•17 years ago
|
||
Peter, did you encounter any problems with the #if on the branch? Cause all.js is regarding these OS/2 and BeOS ifs the same on the branch
|
Assignee | |
Comment 2•17 years ago
|
||
No, I think this is trunk only and somehow caused by a different behavior of the new preprocessor. But if you find a problem, please let me know.
|
||
Comment 3•17 years ago
|
||
Comment on attachment 266006 [details] [diff] [review] #if -> #ifdef r=mkaply
Attachment #266006 -
Flags: review?(cbiesinger) → review+
|
|
Assignee | |
Comment 4•17 years ago
|
||
Checked into trunk.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•