consolidate string types between getItemTitle and nsINavHistoryResultNode.title

RESOLVED WORKSFORME

Status

()

RESOLVED WORKSFORME
12 years ago
8 months ago

People

(Reporter: dietrich, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

12 years ago
from bug 381378:

> >-  char* escapedTitle = nsEscapeHTML(NS_ConvertUTF16toUTF8(title).get());
> >+  char* escapedTitle = nsEscapeHTML(title.get());
> 
> So I was wondering whether we should make GetItemTitle return
> AUTF8String/ACString too.

> why would we do that instead of making them both AString?

Depends on callers... if most of them need AUTF8String, use that, otherwise use
AString, we should unify the two either way.
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
GetItemTitle is currently returning an AUTF8String, so this is WFM (though we're likely going to remove it soon in favour of async apis anyway).
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.