382064 - Remove support for nsIMsgStringService

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Scott MacGregor]

Instead of updating this interface, we should just get rid of it and go through the string bundle service directly. I think we invented this service back in the day when string bundles weren't being cached. Most of the mailnews code already uses string bundles directly but some code in local and compose go through this intermediary service.

Comment 1

[Scott MacGregor]

Attachment: the fix

This patch removes nsIMsgStringService.

mailnews\local was easy to fix, just use the nsIStringBundleService directly.

compose is a mess unfortunately. We use string IDs as both string IDs and error codes that get passed around. This made the transition to using the string bundles directly much harder because sometimes we have to unwrap the 'error' code portion of the ID before calling GetStringFromID. I've tried to improve this a little bit by removing the error code wrapping around all the string IDs that are only used as string IDs. And only methods that can receive error codes try to unwrap the err part of the string ID before calling GetSTringFromID. 

It would still be useful to have someone finish cleaning this up by ending the practice of using the same ID as an error code and a string ID. I'll file a separate bug in case someone wants to tackle that.

Comment 2

[Scott MacGregor]

Comment on attachment 266138 [details] [diff] [review]
the fix

I forgot to ask for a review on this :)

Comment 3

[David :Bienvenu]

Comment on attachment 266138 [details] [diff] [review]
the fix

is there any js that tries to use these removed classes?

Comment 4

[Scott MacGregor]

Attachment: unbit rot the patch

Comment 5

[Scott MacGregor]

Checked in, let's hope I didn't mess up any of the compose error & string ID abuse.

Comment 6

[Christian Eyrich]

This caused a regression, see bug 385220.