382094 - bookmarks root should be a child of the places root

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Dietrich Ayala (:dietrich)]

Comment 1

[Asaf Romano (gone)]

given possible schema/import-schema change, let's get this done by a5.

Comment 2

[Dietrich Ayala (:dietrich)]

Attachment: fix v1

this sets proper parentage for the bookmarks and tag roots.

Comment 3

[Asaf Romano (gone)]

Comment on attachment 266324 [details] [diff] [review]
fix v1

So, I couldn't figure out what's the moz_bookmarks_table about, at all. I'm also not sure what makes bookmarksRoot a root.

Comment 4

[Dietrich Ayala (:dietrich)]

(In reply to comment #3)
> (From update of attachment 266324 [details] [diff] [review])
> So, I couldn't figure out what's the moz_bookmarks_table about, at all.

hm, that string is not present in the patch. where are you seeing that?

> I'm
> also not sure what makes bookmarksRoot a root.
> 

"root" is not the ideal term for these, as the only "root" that has no parent in the folder hierarchy is the places root. in the old world, default_places.html would build the hierarchy, so this patch fixes that regression. the utility of this, however, may change in light of the direction our tagging implementation takes.

Comment 5

[Dietrich Ayala (:dietrich)]

Attachment: fix v2

adds migration code, and tests.

Comment 6

[Asaf Romano (gone)]

Comment on attachment 266794 [details] [diff] [review]
fix v2

r=mano.

Comment 7

[Dietrich Ayala (:dietrich)]

Checking in toolkit/components/places/src/nsNavBookmarks.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp,v  <--  nsNavBookmarks.cpp
new revision: 1.101; previous revision: 1.100
done
Checking in toolkit/components/places/src/nsNavBookmarks.h;
/cvsroot/mozilla/toolkit/components/places/src/nsNavBookmarks.h,v  <--  nsNavBookmarks.h
new revision: 1.43; previous revision: 1.42
done
Checking in toolkit/components/places/tests/bookmarks/test_bookmarks.js;
/cvsroot/mozilla/toolkit/components/places/tests/bookmarks/test_bookmarks.js,v  <--  test_bookmarks.js
new revision: 1.28; previous revision: 1.27
done

Comment 8

[Al Billings [:abillings - ex-MoCo]]

Verified in Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/200707270404 Minefield/3.0a7pre but I browsed the places.sqlite to look at the parent/child relationship.

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv