3821 - [PP] Enter Key should be mapped to Return

Status: VERIFIED FIXED

(Core :: XUL, defect, P2)

Description

[cpratt]

To reproduce this, use macmonkey. I used the March 16 build.

1. Launch apprunner.
2. Type a URL in the URL control. Then, press Enter.
3. Result: a character is added to the URL and that URL is loaded. Because it
isn't what you typed in, this means that it 'fails' (Bad Request) all of the
time.

It does work okay if you press the Return key instead of the Enter key. You can
also see this by clicking into the URL control and pressing Enter - the same
thing happens.

Comment 1

[don]

Re-assinged to [e-mail] and changed component to Widget Set.

Chris, is this for you folks or the XPToolkit?

Comment 2

[karnaze (gone)]

This sounds like an Apprunner specific problem. It is not a problem in viewer. I
don't even have a "return" key, but my "enter" key works just fine in viewer.

Peter, please reassign as appropriate. If you would tell me who should get
apprunner specific problems, I wouldn't have to reassign them to you. Don's name
appears on the apprunner owner list, but he always reassigns them to me!

Comment 3

[cpratt]

If you don't have an Enter key, I can get you a keyboard that has one. It's
possible that the Apple Keyboard II and other older Apple keyboards don't have
an Enter key; it's the one next to the numeric keyboard at the right of the
keyboard (as opposed to the Return key, which is to the right of the
single-quote key, the one you normally use when typing). Under Windows NT, the
Enter key on the numeric keypad works fine.

Comment 4

[Peter Trudelle]

I'm seeing the Enter key add a character, but not load the URL, so I wind up
with just the 'missing character' glyph, not an error.  I get the identical
behavior in Viewer, 3/17 optimized build.  Who owns this URLbar?  It sure isn't
XPToolkit.

Comment 5

[karnaze (gone)]

I didn't notice that this was a Mac bug. I don't know who owns the url bar, but
since it is a Mac problem, I've added Pierre and Don Cone to the cc list.
Maybe one of them can shed some light and/or take the bug.

Comment 6

[Pierre Saslawsky]

Renamed "Enter Key should be mapped to Return"
Reassigned to myself.

Comment 7

[phillip]

this problem also occurs on builds up to and including 99031810 on
redhat linux.

steps to reproduce (bearing in mind this is common):
1. open apprunner
2. leave the numlock key off
3. type http://www.muzilla.org in the location bar,
   hit normal return key (between right-shift and backspace)
4. oops! now select the 'u' and type an 'o'
5. finally, hit enter on the number pad.
6. the url will contain the new hidden character

output of debug statements:
----------------------------------------
URL to load in nsBrowserAppCore is http://www.muzilla.org
rglla.oAlert! did not find a converter or decoderURL to load in nsBrowserAppCore
is http://www.mo
----------------------------------------

Comment 8

[Pierre Saslawsky]

Fixed on the Mac.
Reassigned to <ramiro> to take care of Unix.

Comment 9

[ramiro]

akkana, do you know about this ?

do i need to do anything ?

Comment 10

[ramiro]

akkana, do you know about this ?

do i need to do anything ?

Comment 11

[ramiro]

m5

Comment 12

[Akkana Peck]

It looks to me like we don't need to do anything in linux.  GDK_KP_Enter is
already mapped to NS_VK_RETURN, just like GDK_Return is, and hitting keypad
enter after typing a url in the urlbar does take me to the url (have to hit
either enter or return a couple of times, there's a separate bug on that).

Marking fixed since the Mac problem was apparently fixed.  QA, please verify on
all three platforms.

Comment 13

[phillip]

* REOPENING ON:
    linux apprunner - 1999-04-08-08
    linux now has this problem regardless of the state of the numlock key.
    (just follow the above procedure)

* VERIFIED ON:
    winnt 4.0 - 1999-04-08-10
    macos 851 - 1999-04-08-10

Comment 14

[Akkana Peck]

Yes, sure enough, now I'm seeing it.  Ramiro, I'll look at this unless you want
to keep it.

Comment 15

[Akkana Peck]

Update: Actually, this looks like a GTK problem.  We are indeed doing the same
thing as the Mac is doing: for enter, we set the keyCode to NS_VK_RETURN (same
as for the return key) and the charCode to the keyval of the gtk key event.  The
urlbar jumps to urls based on the keyCode, so it listens to both return and
enter keys.  The problem is that in the meantime, the key event has been passed
to the gtkentry widget, which inserts a space (or something) for the enter key.

I tried forcing the charCode for enter to be the same as the charCode for return
in InitKeyEvent; I also tried forcing aGEK->keyval to be the keyval for return;
but neither had any effect on the key event that the gtkentry widget sees.

Pavlov, we need to find a way to tell the gtkentry to treat enter the same as
return (or ignore it).  I didn't see any clues in gtkentry.h or in nsTextWidget
or nsTextWidgetHelper.  Any ideas?

Comment 16

[stuartp]

akkana - is this still a problem?  I have a few ideas, but am not entirely
sure.  Let me know if its still a problem and i'll go debugging happy.
-- adding to PP radar

Comment 17

[Akkana Peck]

Yes, it's still a problem.  (Does it not happen for you?)

Comment 18

[Chris McAfee]

*** Bug 6228 has been marked as a duplicate of this bug. ***

Comment 19

[Chris McAfee]

This bug is screwing up bugzilla queries, upgrading to p2.

Comment 20

[stuartp]

(could have sworn i updated this last night...)
this happens in all GTK programs.  I am trying to find a way to work around it.

Comment 21

[ramiro]

Marking M8.  If you plan to fix any of these for m7, mark them so.

Comment 22

[leger]

Moving all Widget Set bugs, past and present, to new HTML Form Controls
component per request from karnaze.  Widget Set component will be retired
shortly.

Comment 23

[stuartp]

moving to XP Toolkit/Widgets since these are not HTML form controls

Comment 24

[Peter Trudelle]

mass-moving all m12 bugs to m13

Comment 25

[Paul MacQuiddy]

dividing up phillips qa contact bugs, he no longer works here

Comment 26

[Stuart Parmenter]

fixed baby!

Comment 27

[Eli Goldberg]

Using this morning's builds on NT 4.0 SP5, Mac OS 8.6 & RH Linux 6.0/GNOME, both
the Enter key now works as the Return key did.

(Yup, and the Return key still works, too...)