382101 - Can't move bookmark folder to the "root"

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Benjamin Smedberg]

When bookmarks imported to places, things were a little wrong, but that's not what this bug is about:

Basic description: I can't move a folder of bookmarks from the personal toolbar folder to the "root" bookmarks menu.

Steps to reproduce:

1) Create a folder of bookmarks in the personal toolbar
2) "Organize Bookmarks" and Select the folder
3) Choose "Move". Try to figure out how to move the folder so it shows up in the Bookmarks folder

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[(not reading, please use [e-mail] instead)]

Comment on attachment 266427 [details] [diff] [review]
patch

Asaf, instead of that custom function, why not use selectFolders() or selectPlaceURI()?

for selectPlaceURI(), watch out for perf issues like bug #381750.  See also bug #382264.

for selectFolders(), watch out for perf issues like bug #382195 (fix pending review, if you have cycles).

finally, since we have to use setTimeout() (to work around bug #373944), can you can add a note to that bug about backing out this setTimeout() when / if that bug gets fixed?

Comment 3

[Asaf Romano (gone)]

does selectFolders expend the passed-in folder? If it doesn't, the custom functions are simply cleaner in this context. selectPlaceURI should be deprecated imho.

I will add a backout-note comment about the workaround on checkin.

Comment 4

[(not reading, please use [e-mail] instead)]

> does selectFolders expend the passed-in folder?

yes, but you will want the fix for bug #382195.

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 266427 [details] [diff] [review]
patch

Asaf, I'm going to clear the review, assuming that you are working on a patch that uses selectFolders()

Comment 6

[Asaf Romano (gone)]

Attachment: patch

Comment 7

[(not reading, please use [e-mail] instead)]

Comment on attachment 266679 [details] [diff] [review]
patch

r=sspitzer

Comment 8

[Asaf Romano (gone)]

mozilla/browser/components/places/content/moveBookmarks.js 1.6
mozilla/browser/components/places/content/moveBookmarks.xul 1.4

Comment 9

[Al Billings [:abillings - ex-MoCo]]

Verification blocked by Bug 389912 though the steps here aren't really clear.

Comment 10

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007112604 Minefield/3.0b2pre

Comment 11

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv