382217 - move browser/ Makefiles from allmakefiles.sh to browser/makefiles.sh

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: create browser/makefiles.sh, kill those entries from allmakefiles

This removes browser/ Makefiles from allmakefiles.sh and puts them into
browser/makefiles.sh which gets called by allmakefiles automatically now when
--enable-application=browser

I hope that's all?

Comment 1

[Robert Kaiser]

Comment on attachment 266350 [details] [diff] [review]
create browser/makefiles.sh, kill those entries from allmakefiles  

>Index: browser/makefiles.sh
>===================================================================
>+# Portions created by the Initial Developer are Copyright (C) 2006
>+# the Initial Developer. All Rights Reserved.

nit: It's 2007, not 2006 ;-)

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1.1 with corrected year

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 266359 [details] [diff] [review]
Patch v1.1 with corrected year

Looks good to me, thanks!

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 266359 [details] [diff] [review]
Patch v1.1 with corrected year

Do I need a second review to get this patch checked in?

Comment 5

[Benjamin Smedberg]

Comment on attachment 266359 [details] [diff] [review]
Patch v1.1 with corrected year

Not really, I've delegate this to bent.

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Fixed on trunk.