Closed Bug 382217 Opened 13 years ago Closed 13 years ago

move browser/ Makefiles from allmakefiles.sh to browser/makefiles.sh

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla3 alpha6

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file, 1 obsolete file)

This removes browser/ Makefiles from allmakefiles.sh and puts them into
browser/makefiles.sh which gets called by allmakefiles automatically now when
--enable-application=browser

I hope that's all?
Attachment #266350 - Flags: review?(bent.mozilla)
Comment on attachment 266350 [details] [diff] [review]
create browser/makefiles.sh, kill those entries from allmakefiles  

>Index: browser/makefiles.sh
>===================================================================
>+# Portions created by the Initial Developer are Copyright (C) 2006
>+# the Initial Developer. All Rights Reserved.

nit: It's 2007, not 2006 ;-)
Attachment #266350 - Attachment is obsolete: true
Attachment #266359 - Flags: review?(bent.mozilla)
Attachment #266350 - Flags: review?(bent.mozilla)
Comment on attachment 266359 [details] [diff] [review]
Patch v1.1 with corrected year

Looks good to me, thanks!
Attachment #266359 - Flags: review?(bent.mozilla) → review+
Comment on attachment 266359 [details] [diff] [review]
Patch v1.1 with corrected year

Do I need a second review to get this patch checked in?
Attachment #266359 - Flags: review?(benjamin)
Comment on attachment 266359 [details] [diff] [review]
Patch v1.1 with corrected year

Not really, I've delegate this to bent.
Attachment #266359 - Flags: review?(benjamin) → review+
Whiteboard: [checkin needed]
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Whiteboard: [checkin needed]
Target Milestone: --- → Firefox 3 alpha6
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 3 alpha6 → mozilla3 alpha6
You need to log in before you can comment on or make changes to this bug.