Closed Bug 382218 Opened 13 years ago Closed 13 years ago

move mail/ Makefiles from allmakefiles.sh to mail/makefiles.sh

Categories

(Thunderbird :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file, 1 obsolete file)

This removes mail/ Makefiles from allmakefiles.sh and puts them into
mail/makefiles.sh which gets called by allmakefiles automatically now when
--enable-application=mail
Attachment #266353 - Flags: review?(bent.mozilla)
Comment on attachment 266353 [details] [diff] [review]
create mail/makefiles.sh, kill those entries from allmakefiles

>Index: mail/makefiles.sh
>===================================================================
>+# Portions created by the Initial Developer are Copyright (C) 2006
>+# the Initial Developer. All Rights Reserved.

nit: It's 2007, not 2006 ;-)
Attachment #266353 - Attachment is obsolete: true
Attachment #266357 - Flags: review?(bent.mozilla)
Attachment #266353 - Flags: review?(bent.mozilla)
Comment on attachment 266357 [details] [diff] [review]
Patch v1.1 with corrected year

Looks fine.
Attachment #266357 - Flags: review?(bent.mozilla) → review+
Comment on attachment 266357 [details] [diff] [review]
Patch v1.1 with corrected year

looks good to me too. Thanks  Henrik. I'll try to land this today if someone doesn't beat me to it.
Attachment #266357 - Flags: superreview+
Thanks for the patch Henrik! I wonder if we should do something similar for the Makefiles in mailnews?
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
we definately should do something like that, and call the mailnews/makefiles.sh from both suite's and mail's variant, I believe.
(In reply to comment #5)
> Thanks for the patch Henrik! I wonder if we should do something similar for the
> Makefiles in mailnews?

As Mark pointed out this is already done. One difference there is no .sh file extension. See http://lxr.mozilla.org/seamonkey/source/mailnews/makefiles
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.