382246 - nsImageWin.cpp doesn't compile on Cygwin/GCC

Status: RESOLVED DUPLICATE of bug 363592

(Core Graveyard :: GFX: Win32, defect)

Description

[Mikko Ohtamaa]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fi; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: Mozilla 1.8 branch

nsImageWin.cpp is the only C++ source file in Mozilla tree using MSVC __try/__except structure - I grep'ed the source tree. It's for handling a possible printer driver bug. This workaround prevents compiling the file on GCC - GCC doesn't support __try.

Reproducible: Always

Steps to Reproduce:
1. Compile Minimo on Windows XP/Cygwin
2. Wait until it hits nsImageWin.cpp
Actual Results:  
c:/minimo/mozilla/gfx/src/windows/nsImageWin.cpp: In function `void CompositeBitsInMemory(HDC__*, int, int, int, int, int, int, int, int, PR
Int32, PRUint8*, MONOBITMAPINFO*, PRUint8*, tagBITMAPINFOHEADER*, PRInt16)':
c:/minimo/mozilla/gfx/src/windows/nsImageWin.cpp:2049: error: `__try' undeclared (first use this function)
c:/minimo/mozilla/gfx/src/windows/nsImageWin.cpp:2049: error: (Each undeclared identifier is reported only once for each function it appears
 in.)
c:/minimo/mozilla/gfx/src/windows/nsImageWin.cpp:2049: error: expected `;' before '{' token
c:/minimo/mozilla/gfx/src/windows/nsImageWin.cpp:2055: error: `__except' undeclared (first use this function)
c:/minimo/mozilla/gfx/src/windows/nsImageWin.cpp:2055: error: expected `;' before '{' token


This could be compiler #ifdef'ed so building would work on non-MSVC compilers too.

Comment 1

[Eli Friedman]

Cygwin/GCC is unsupported as far as I know.  See http://developer.mozilla.org/en/docs/Windows_Build_Prerequisites_on_the_1.7_and_1.8_Branches.