382248 - problems when I remove places.sqlite (we don't re-import bookmarks.html and we lose all bookmarks)

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

problems when I remove places.sqlite (we don't re-import bookmarks.html and we lose all bookmarks)

here's what I'm doing:

1)  with the trunk, create a new profile, you get the default bookmarks
2)  exit.
3)  remove places.sqlite 
4)  start back up, and we did not import bookmarks.html.  instead, we create an empty places db.  (so the bookmarks are gone.)
5)  on quit, we'll overwrite bookmarks.html with the empty places.sqlite data

I think we should make it so if someone removes places.sqlite we re-import bookmarks.html.  I think we used to do that.

Comment 1

[Dietrich Ayala (:dietrich)]

Attachment: fix v1 - set pref if file not exists

sets the "do import bookmarks" pref if we have to create the places.sqlite file.

Comment 2

[(not reading, please use [e-mail] instead)]

Comment on attachment 266435 [details] [diff] [review]
fix v1 - set pref if file not exists

r=sspitzer

thanks dietrich for fixing this before a5.

Comment 3

[Dietrich Ayala (:dietrich)]

Checking in toolkit/components/places/src/nsNavHistory.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.cpp,v  <--  nsNavHistory.cpp
new revision: 1.128; previous revision: 1.127
done

Comment 4

[Heinrich Witt]

With latest build my Bookmarks Tollbar is empty and no more passwords are stored. With a clean profile i have to import my bookmarks because they were not taken over from bookmarks.html.
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a5pre) Gecko/20070530 Firefox/3.0a5pre ID:2007053005 [cairo] 

Comment 5

[(not reading, please use [e-mail] instead)]

as far as passwords, cc'ing dolske.

as far as your bookmarks toolbar, what version of firefox were you using before 2007053005?

Comment 6

[Heinrich Witt]

2007052910

Comment 7

[Justin Dolske [:Dolske]]

For passwords, you might try enabling the "signons.debug" pref in about:config [add it if it's not there, set to true] and look in the error console for messages. You may be seeing something like bug 381155, comments 6-9.

Comment 8

[Tracy Walker [:tracy]]

verified with Windows trunk build from 20070620

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv