382293 - sync maiutil code with gail/gailutil.c

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Ginn Chen]

The maiutil is based gailutil.
But I found some differences in *_util_add_key_event_listener, *_util_remove_key_event_listener part.

I think we can change the code of maiutil to make it easier to be maintained.

Also I found a memory leak mai_util_add_global_event_listener, which was fixed in gailutil 3 years ago.

Comment 1

[Ginn Chen]

Attachment: patch

Comment 2

[Aaron Leventhal]

Comment on attachment 266448 [details] [diff] [review]
patch

Ginn, I don't feel qualified to review this. Perhaps Evan can help?

Comment 3

[Evan Yan]

Comment on attachment 266448 [details] [diff] [review]
patch

looks good.

nit:

+        info->key_event = atk_key_event_from_gdk_event_key (event);
+        info->func_data = func_data;
+        consumed = g_hash_table_foreach_steal (new_hash, notify_hf, info);
         g_hash_table_destroy (new_hash);
-        g_free (keyEvent);
     }
+    g_free(info->key_event);

the last line can be moved up into the block.