382348 - forcing frame reconstruction on a menu image after a menu has been popped down causes the menu image to disappear

Status: RESOLVED WORKSFORME

(Core :: XUL, defect)

Description

[Mike Kaply [:mkaply]]

Attachment: Testcase

If you set opacity an a menu image after the menu has been popped down, the menu image gets set to 0 width and 0 height.

Testcase attached.

Comment 1

[Adam Guthrie]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a5pre) Gecko/20070529 Minefield/3.0a5pre

This is WORKSFORME on a Linux trunk build from today.

Comment 2

[Mike Kaply [:mkaply]]

Argh. You're right. Works on trunk. I would LOVE a branch fix for this. I wonder what fixed it...

Comment 3

[Mike Kaply [:mkaply]]

Neil:

Would you have any idea what would have fixed this for trunk and if there is any workaround?

Comment 4

[Adam Guthrie]

This was fixed between 2007-02-23-04 and 2007-02-24-04 on trunk: http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-02-23+03&maxdate=2007-02-24+05&cvsroot=%2Fcvsroot

which probably means that bug 370379 fixed this. :\

Comment 5

[Eli Friedman]

Attachment: Testcase that breaks on trunk

This is an XUL reframe bug.

You can probably work around it by setting the default opacity on the image to 0.99; that's not really right, but nobody will be able to tell the difference.

Comment 6

[Eli Friedman]

(I guess that testcase actually doesn't work on the branch because we don't force a reframe for changes to list-style-position there; must have been a trunk-only fix.  What exactly we need to reframe for is always changing, so it's kinda difficult to make a testcase for this kind of scenario.)

Another branch workaround is to force the parent to reframe by adding something like  "this.parentNode.style.position = 'relative';.

It'd be nice to get this properly fixed for 1.9, but I don't think I can help you there; for the moment, I consider frame construction to be black magic :(

Comment 7

[Mike Kaply [:mkaply]]

> this.parentNode.style.position = 'relative';.

What is the this in this scenario? The button?

> default opacity on the image to 0.99

Do you mean from a CSS perspective?

Comment 8

[Eli Friedman]

(In reply to comment #7)
> > this.parentNode.style.position = 'relative';.
> 
> What is the this in this scenario? The button?

I got it to work by adding it to the JS in the testcase; I'm not exactly sure how much you need to reframe.

> > default opacity on the image to 0.99
> 
> Do you mean from a CSS perspective?

Yeah, style="opacity: 0.99" or whatever equivalent is needed.

Comment 9

[Mike Kaply [:mkaply]]

Can't recreate either one anymore.