forcing frame reconstruction on a menu image after a menu has been popped down causes the menu image to disappear

RESOLVED WORKSFORME

Status

()

Core
XUL
RESOLVED WORKSFORME
11 years ago
7 years ago

People

(Reporter: mkaply, Unassigned)

Tracking

({testcase})

Trunk
testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

1010 bytes, application/vnd.mozilla.xul+xml
Details
1.00 KB, application/vnd.mozilla.xul+xml
Details
(Reporter)

Description

11 years ago
Created attachment 266498 [details]
Testcase

If you set opacity an a menu image after the menu has been popped down, the menu image gets set to 0 width and 0 height.

Testcase attached.

Comment 1

11 years ago
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a5pre) Gecko/20070529 Minefield/3.0a5pre

This is WORKSFORME on a Linux trunk build from today.
Keywords: testcase
Version: unspecified → Trunk
(Reporter)

Comment 2

11 years ago
Argh. You're right. Works on trunk. I would LOVE a branch fix for this. I wonder what fixed it...
Version: Trunk → 1.8 Branch
(Reporter)

Comment 3

11 years ago
Neil:

Would you have any idea what would have fixed this for trunk and if there is any workaround?

Comment 5

11 years ago
Created attachment 266548 [details]
Testcase that breaks on trunk

This is an XUL reframe bug.

You can probably work around it by setting the default opacity on the image to 0.99; that's not really right, but nobody will be able to tell the difference.

Comment 6

11 years ago
(I guess that testcase actually doesn't work on the branch because we don't force a reframe for changes to list-style-position there; must have been a trunk-only fix.  What exactly we need to reframe for is always changing, so it's kinda difficult to make a testcase for this kind of scenario.)

Another branch workaround is to force the parent to reframe by adding something like  "this.parentNode.style.position = 'relative';.

It'd be nice to get this properly fixed for 1.9, but I don't think I can help you there; for the moment, I consider frame construction to be black magic :(
Summary: Setting opacity on a menu image doesn't work after the menu has been popped down → after the menu has been popped down
Version: 1.8 Branch → Trunk

Updated

11 years ago
Summary: after the menu has been popped down → forcing frame reconstruction on a menu image after a menu has been popped down causes the menu image to disappear
(Reporter)

Comment 7

11 years ago
> this.parentNode.style.position = 'relative';.

What is the this in this scenario? The button?

> default opacity on the image to 0.99

Do you mean from a CSS perspective?

Comment 8

11 years ago
(In reply to comment #7)
> > this.parentNode.style.position = 'relative';.
> 
> What is the this in this scenario? The button?

I got it to work by adding it to the JS in the testcase; I'm not exactly sure how much you need to reframe.

> > default opacity on the image to 0.99
> 
> Do you mean from a CSS perspective?

Yeah, style="opacity: 0.99" or whatever equivalent is needed.

Updated

10 years ago
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: xptoolkit.menus → xptoolkit.widgets
(Reporter)

Comment 9

7 years ago
Can't recreate either one anymore.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.