382383 - nsDocShell::LoadURI discards LOAD_FLAGS_FIRST_LOAD

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Shawn Wilsher :sdwilsh]

ConvertLoadTypeToDocShellLoadInfo doesn't like it, but we need it later.  Patch coming.

Comment 1

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Comment 2

[Boris Zbarsky [:bzbarsky]]

Er... under what conditions is that flag actually needed here?  That is, who's passing it to the nsIWebNavigation method?  I'd really like to check in a regression test for this, because this code is _really_ fragile.

Also, if we do want to do this, I'd like a single constant for all the flags we want to pass in here instead of basically retyping it twice.

Comment 3

[Shawn Wilsher :sdwilsh]

It came up while I was trying to work on Bug 346561.  So, nobody uses it yet, but I might have to, unless there's a better/easier way for me to accomplish that task.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Ah, I see.  Yeah, let's have a single constant, and looks reasonable... 

Comment 5

[Shawn Wilsher :sdwilsh]

Comment on attachment 266538 [details] [diff] [review]
v1.0

For my own reference - make a constant that holds all the flags that are problematic, and just do one operation.

Comment 6

[Shawn Wilsher :sdwilsh]

Attachment: v1.1

OK, I believe this is what you are looking for.  I'll wait for requesting sr.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 267162 [details] [diff] [review]
v1.1

I like!

Comment 8

[Shawn Wilsher :sdwilsh]

Checking in docshell/base/nsDocShell.cpp;
new revision: 1.835; previous revision: 1.834
Checking in docshell/base/nsDocShellLoadTypes.h;
new revision: 1.5; previous revision: 1.4