Closed Bug 382464 Opened 14 years ago Closed 12 years ago

in toolbar.xml's itemChanged() [itemRemoved(), itemReplaced(), etc], use viewIndex to find the desired node

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: moco, Unassigned)

Details

(Keywords: perf, Whiteboard: [TSnappiness])

in toolbar.xml's itemChanged() [itemRemoved(), itemReplaced(), etc], use viewIndex to find the desired node.

spun off from bug #379591, where Asaf wrote:

>+          var children = this._self.childNodes;
>+          for (var i = 0; i < children.length; i++) {
>+            if (children[i].node == aNode) {
>+              button = children[i];
>+              break;

Please file a RFE on using node's viewIndex instead, like we do in PlacesTreeView (http://lxr.mozilla.org/seamonkey/source/browser/components/places/content/treeView.js)
Note, before we do this, we should confirm what the performance savings would actually be.  

I don't think it is going to be very much, and the current code has the benefit of being simple.
OS: Windows XP → All
Hardware: x86 → All
Whiteboard: [TSnappiness]
Fixing that some other way in bug 498130.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.