382464 - in toolbar.xml's itemChanged() [itemRemoved(), itemReplaced(), etc], use viewIndex to find the desired node

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

in toolbar.xml's itemChanged() [itemRemoved(), itemReplaced(), etc], use viewIndex to find the desired node.

spun off from bug #379591, where Asaf wrote:

>+          var children = this._self.childNodes;
>+          for (var i = 0; i < children.length; i++) {
>+            if (children[i].node == aNode) {
>+              button = children[i];
>+              break;

Please file a RFE on using node's viewIndex instead, like we do in PlacesTreeView (http://lxr.mozilla.org/seamonkey/source/browser/components/places/content/treeView.js)

Comment 1

[(not reading, please use [e-mail] instead)]

Note, before we do this, we should confirm what the performance savings would actually be.  

I don't think it is going to be very much, and the current code has the benefit of being simple.

Comment 2

[Asaf Romano (gone)]

Fixing that some other way in bug 498130.

Comment 3

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv