Closed Bug 382473 Opened 17 years ago Closed 16 years ago

Some bookmarks menu items don't have menu ID

Categories

(Firefox :: Menus, defect)

Product:
Firefox
Component:
Menus
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
VERIFIED DUPLICATE of bug 473829

People

(Reporter: nnbugzilla, Unassigned)

References

Details

Since the Places backend was enabled recently, the first 4 items in Bookmarks menu don't have IDs.  That means extensions such as Menu Editor can't modify these items.

Not sure if this should be a new bug, or if bug 326241 would apply.  Since that bug is old and hasn't seen any activity in over a year, I went ahead and opened a new bug.
I don't know enough about how the menus work in Firefox, or how Menu Editor "knows" what menu items are available, so I could be totally wrong here: can't the browser.xul file be modified to add the IDs or something?
Yes, that's what needs to happen. Can you attach a patch? :)
Sorry, Gavin.  I understand the concept, but not the specifics.  I tried altering browser.xul to add IDs on my local copy, but it didn't work.  Also, it looks like some of the menu items already have "menu id" in the XUL file, but they still don't work with Menu Editor, so I don't know what's wrong.
Is there any documentation on how menu IDs are added, and what kind of nomenclature needs to be used for the IDs?  If there is sufficient documentation or specs, I can try adding IDs to the items that don't have them and submit a patch.
This seems to have been fixed by bug 473829.  Should I mark this bug as FIXED or INVALID?
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → DUPLICATE
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.