38249 - Incorporate the sample XPCOM plugin into the autoconf build

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Braden]

npsimple (the sample XPCOM plugin) needs love. I'm gonna give it some, starting
with an option to configure to enable building it. Expect patches to follow
shortly.

Comment 1

[cls]

Why even bother is the configure option?  Get it to work and turn it on by
default.  If anything, I'd say just put it under the ENABLE_TESTS ifdef.

Comment 2

[Braden]

That's fine by me.

Comment 3

[Braden]

Attachment: Patch to mozilla/modules/plugin/Makefile.in

Comment 4

[Braden]

Changed summary to be more general.

The attached patch simply adds mozilla/modules/plugin/test contingent on
ENABLE_TESTS, as discussed.

Note the dependency, bug 38257. npsimple.cpp requires a minor change before it
will compile.

Comment 5

[cls]

Patch has been checked in.

Comment 6

[justin morey]

Attachment: patch to fix beos build

Comment 7

[justin morey]

i've attached a patch which adds a stub PlatformInstance struct, as well as a
stub SimplePluginInstance implementation, to npsimple.cpp, allowing it to
compile on the beos.

Comment 8

[Jon Granrose]

marking verified.

justin, I'd file a separate bug about npsimple on beos and attach the patch 
there.

Comment 9

[justin morey]

cls did check in my patch already, and the beos problem is fixed...