Closed
Bug 38249
Opened 24 years ago
Closed 24 years ago
Incorporate the sample XPCOM plugin into the autoconf build
Categories
(SeaMonkey :: Build Config, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: braden, Assigned: cls)
References
Details
Attachments
(2 files)
443 bytes,
patch
|
Details | Diff | Splinter Review | |
4.23 KB,
patch
|
Details | Diff | Splinter Review |
npsimple (the sample XPCOM plugin) needs love. I'm gonna give it some, starting with an option to configure to enable building it. Expect patches to follow shortly.
Why even bother is the configure option? Get it to work and turn it on by default. If anything, I'd say just put it under the ENABLE_TESTS ifdef.
Changed summary to be more general. The attached patch simply adds mozilla/modules/plugin/test contingent on ENABLE_TESTS, as discussed. Note the dependency, bug 38257. npsimple.cpp requires a minor change before it will compile.
Keywords: patch
Summary: Add configure option for building npsimple → Incorporate the sample XPCOM plugin into the autoconf build
Patch has been checked in.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 6•24 years ago
|
||
Comment 7•24 years ago
|
||
i've attached a patch which adds a stub PlatformInstance struct, as well as a stub SimplePluginInstance implementation, to npsimple.cpp, allowing it to compile on the beos.
Comment 8•24 years ago
|
||
marking verified. justin, I'd file a separate bug about npsimple on beos and attach the patch there.
Status: RESOLVED → VERIFIED
Comment 9•24 years ago
|
||
cls did check in my patch already, and the beos problem is fixed...
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•