382504 - can't (un)expand threads

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Tuukka Tolvanen (sp3000)]

tbird trunk today, linux

 1. click twisty to expand a thread
     -> twisty state changes, no message rows appear
    expected: show messages in thread
 2. unexpand a thread, not last row
     -> twisty state changes, bunch of unrelated msg rows below deleted
    expected: hide messages in thread except topmost

bug 362680 (tree) or bug 379070 (nsIMsgThread)?

Comment 1

[Scott MacGregor]

I was telling Tuukka in IRC, I can't reproduce this on a Windows build built from earlier this morning.

He also got this JS error:

Error: uncaught exception: [Exception... "Component returned failure code: 0xbfbced1c [nsITreeView.toggleOpenState]"  nsresult: "0xbfbced1c (<unknown>)"  location: "JS frame :: chrome://global/content/bindings/tree.xml :: changeOpenState :: line 220"  data: no]

Comment 2

[Tuukka Tolvanen (sp3000)]

oh, yeah, that exception on expand, none on unexpand

Comment 3

[Tuukka Tolvanen (sp3000)]

still broken with bug 362680 reverted, and 2007-05-29 15:00 PDT works, so bug 379070 sounds likely

Comment 4

[Scott MacGregor]

cc'ing Joerg. He might be able to reproduce and help figure out what we regressed.

Comment 5

[Scott MacGregor]

Attachment: does this help at all?

Does this patch help the problem at all?

Comment 6

[Tuukka Tolvanen (sp3000)]

no.

Comment 7

[Joerg Bornemann]

Hm...can't reproduce this on Windows too. I will check this on my linux build this afternoon.

Comment 8

[Tuukka Tolvanen (sp3000)]

I tried this with an older test profile and it worked there. It started failing there as well after deleting an msf. Try that :)

Comment 9

[Magnus Melin [:mkmelin]]

Seeing it too (on linux). It also seems to hide messages when trying to contract the thread.

Comment 10

[Scott MacGregor]

Comment on attachment 266671 [details] [diff] [review]
does this help at all?

I landed this patch along with some other fixes to nsMsgThread as part of another bug. Obsoleting.

Tuukka, can you update nsMsgThread.cpp one more time and see if you still reproduce this?

I just deleted inbox.msf and still don't see this but I'm running with the patch I checked in this morning to nsMsgGroupThread.cpp

Comment 11

[Scott MacGregor]

nsMsgGroupThread.cpp --> nsMsgThread.cpp

Comment 12

[Phil Ringnalda (:philor)]

I'm still seeing it with a Mac build from half an hour ago - new profile, create a news.mozilla.org account, subscribe to m.d.a.thunderbird, download 500 headers, click the first triangle and it turns without opening, click it again and it hides the thread below it.

Comment 13

[Tuukka Tolvanen (sp3000)]

perhaps related, turning threading on or off results in
    WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file
    mozilla/mailnews/base/util/nsMsgDBFolder.cpp, line 4142
roughly one for each thread >1 msg

Comment 14

[Joerg Bornemann]

I can reproduce it now. In nsMsgThreadEnumerator::GetNext the variable rv must be initialized to NS_OK. Then everything will work fine...again.

Comment 15

[Joerg Bornemann]

Attachment: bugfix

this will fix the issue

Comment 16

[Joerg Bornemann]

Attachment: bugfix

what the ... is wrong with my diffs?? second try

Comment 17

[Joerg Bornemann]

Attachment: bugfix version 2

maybe this is nicer code

Comment 18

[Scott MacGregor]

Comment on attachment 266878 [details] [diff] [review]
bugfix version 2

that makes sense. I'll check this in right now. Good find!