382567 - Use GetNativeInterface, GetAccessibleWrap instead of CAST

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Ginn Chen]

I think using nsIAccessible::GetNativeInterface is a safer, cleaner way than NS_STATIC_CAST nsIAccessible to nsAccessibleWrap and then GetAtkObject().

And we can use
nsAccessibleWrap *accWrap = GetAccessible(aAtkObj);
instead of
nsAccessibleWrap *accWrap = NS_REINTERPTET_CAST(MaiAtkObject*, aAtkObj)->accWrap;

Comment 1

[Ginn Chen]

Attachment: patch

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 266723 [details] [diff] [review]
patch

I like this approach. Probably you would save some code lines if you add GetAtkObject(nsIAccessible*) like GetAccessibleWrap(). But it's not worth to do. Also you removed checking of nsresult but it's safely to have it but I'm sure you know what you do :).

Comment 3

[Ginn Chen]

There is a typo in my patch, sorry for that.
+    AtkObject *cellAtkObj = ATK_OBJECT(cellAtkObj);
should be
+    AtkObject *cellAtkObj = ATK_OBJECT(cellAtkObjPtr);