I think using nsIAccessible::GetNativeInterface is a safer, cleaner way than NS_STATIC_CAST nsIAccessible to nsAccessibleWrap and then GetAtkObject(). And we can use nsAccessibleWrap *accWrap = GetAccessible(aAtkObj); instead of nsAccessibleWrap *accWrap = NS_REINTERPTET_CAST(MaiAtkObject*, aAtkObj)->accWrap;
Created attachment 266723 [details] [diff] [review] patch
Attachment #266723 - Flags: review?(surkov.alexander)
Comment on attachment 266723 [details] [diff] [review] patch I like this approach. Probably you would save some code lines if you add GetAtkObject(nsIAccessible*) like GetAccessibleWrap(). But it's not worth to do. Also you removed checking of nsresult but it's safely to have it but I'm sure you know what you do :).
Attachment #266723 - Flags: review?(surkov.alexander) → review+
There is a typo in my patch, sorry for that. + AtkObject *cellAtkObj = ATK_OBJECT(cellAtkObj); should be + AtkObject *cellAtkObj = ATK_OBJECT(cellAtkObjPtr);
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.