382640 - crash [@ nsMsgHdr::IsParentOf]

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Tuukka Tolvanen (sp3000)]

Attachment: bt

tbird trunk 2007-05-30&31, linux. see also TB32697961 TB32691401, guess it's not just me ;)

Bug 379070 msgthread foo sounds likely based on dates and stack

no str, sorry, got this twice pretty randomly

Comment 1

[Tuukka Tolvanen (sp3000)]

ah, attachment 266671 [details] [diff] [review] from bug 382504 might prevent the crash here with
-      if (NS_SUCCEEDED(rv))
+      if (NS_SUCCEEDED(rv) && curHdr)
       {
         if (hdr->IsParentOf(curHdr))
in nsMsgThread::AddChild

Comment 2

[Scott MacGregor]

Attachment: the fix

Add back the null ptr checks along with the NS_SUCCEEDED macros.

This should fix a couple different crashes that are floating around.

Comment 4

[Joerg Bornemann]

Wow...for the future I know that the statement "There's no need to check for a failure code and a null value." only applies to do_QueryInterface. I'm sorry for the inconveniences.

Comment 5

[Scott MacGregor]

fix checked in.