Closed Bug 382640 Opened 16 years ago Closed 16 years ago

crash [@ nsMsgHdr::IsParentOf]

Categories

(MailNews Core :: Backend, defect)

Product:
MailNews Core
Component:
Backend
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: tuukka.tolvanen, Assigned: mscott)

References

Details

(Keywords: crash)

Crash Data

Attachments

(2 files)

bt
8.67 KB, text/plain
Details
the fix
4.23 KB, patch
Bienvenu
: superreview+
Details | Diff | Splinter Review
Attached file bt — 
tbird trunk 2007-05-30&31, linux. see also TB32697961 TB32691401, guess it's not just me ;)

Bug 379070 msgthread foo sounds likely based on dates and stack

no str, sorry, got this twice pretty randomly
ah, attachment 266671 [details] [diff] [review] from bug 382504 might prevent the crash here with
-      if (NS_SUCCEEDED(rv))
+      if (NS_SUCCEEDED(rv) && curHdr)
       {
         if (hdr->IsParentOf(curHdr))
in nsMsgThread::AddChild
Attached patch the fix — — Splinter Review 
Add back the null ptr checks along with the NS_SUCCEEDED macros.

This should fix a couple different crashes that are floating around.
Assignee: nobody → mscott
Status: NEW → ASSIGNED
Attachment #266786 - Flags: superreview?(bienvenu)
Attachment #266786 - Flags: superreview?(bienvenu) → superreview+
Wow...for the future I know that the statement "There's no need to check for a failure code and a null value." only applies to do_QueryInterface. I'm sorry for the inconveniences.
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Product: Core → MailNews Core
Crash Signature: [@ nsMsgHdr::IsParentOf]
You need to log in before you can comment on or make changes to this bug.