Closed Bug 382690 Opened 17 years ago Closed 16 years ago

In about:config, make accel+f focus the filter box instead of invoking the find bar

Categories

(Toolkit :: Preferences, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.1b2

People

(Reporter: bugzilla-graveyard, Assigned: steffen.wilberg)

References

()

Details

Attachments

(1 file, 3 obsolete files)

See also bug 382688. We should allow Cmd-F to focus the Filter field, as we do in bookmarks and history, rather than invoking the Find dialog when about:config is the active page.
Summary: Command-F should focus Filter field rather than invoking Find → Command-F from about:config should focus Filter field rather than invoking Find
Hijacking...
Component: Toolbars & Menus → Preferences
OS: Mac OS X → All
Product: Camino → Toolkit
QA Contact: toolbars → preferences
Hardware: Macintosh → All
Version: unspecified → Trunk
Attached patch patch (obsolete) — Splinter Review
Make Accel+F focus the filter box.
I patched xpfe as well since this was a Camino bug...
The toolkit part builds on bug 449669.
Assignee: nobody → steffen.wilberg
Status: NEW → ASSIGNED
Attachment #333006 - Flags: review?(mano)
Attached patch unbitrotted (obsolete) — Splinter Review
Unbitrotted, and even shorter (2 lines) due to xpfe removal.
Attachment #333006 - Attachment is obsolete: true
Attachment #337330 - Flags: review?(mano)
Attachment #333006 - Flags: review?(mano)
Attachment #337330 - Flags: review?(mano) → review?(neil)
Hmm, this doesn't work very nicely if you press Accel+F when the warning is still active... although I notice that focusing the checkbox and hitting Enter will also trigger a JS exception...
Attached patch patch v1.1 (obsolete) — Splinter Review
Thanks for the quick response. This patch fixes both problems mentioned in comment 4. While the warningScreen is displayed, Accel+F neither steals focus from the button (like the previous patch did), nor does it display the findbar (like the current code does). And focusing the checkbox and pressing enter doesn't trigger an exception anymore.
Attachment #337330 - Attachment is obsolete: true
Attachment #338947 - Flags: review?
Attachment #337330 - Flags: review?(neil)
Attachment #338947 - Flags: review? → review?(neil)
So, it turns out that there's an alternative (better?) way of doing this that I remembered only because I reviewed the patch that implemented it: bug 437640 made it so we can simply set the disabled="true" attribute on the keyset and it will disable all the keys in the keyset. However there's a slight difference in behaviour in that with disabled="true" the Accel+F will invoke Find when the warning page is displayed while with your version it won't. Thoughts?
Enabling the keyset once the configTree is shown is a bit cleaner indeed.

I don't think it's much of a problem that you can open the find bar by pressing accel+f. I wonder though why you can't actually find anything...
Attachment #338947 - Attachment is obsolete: true
Attachment #339348 - Flags: review?(neil)
Attachment #338947 - Flags: review?(neil)
Attachment #339348 - Attachment is patch: true
Attachment #339348 - Attachment mime type: application/octet-stream → text/plain
Attachment #339348 - Flags: review?(neil) → review+
http://hg.mozilla.org/mozilla-central/rev/93928936b1ab
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Summary: Command-F from about:config should focus Filter field rather than invoking Find → In about:config, make accel+f focus the filter box instead of invoking the find bar
Target Milestone: --- → mozilla1.9.1b1
I thought we're string frozen for b1...
Please back this out ASAP!

You've broken every Thunderbird locale with that change and we have the release cutoff-date tonight at 23:59 PDT.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
After discussion on #developers with ss I backed this patch out due to being in the string freeze (and no apparent discussion that this was a late l10n change).
Ok, sorry for not realizing the Thunderbird string freeze applies to toolkit code as well, and for not being around later on.
(In reply to comment #12)
> Ok, sorry for not realizing the Thunderbird string freeze applies to toolkit
> code as well, and for not being around later on.

Actually our comments have been a bit unclear here. Firefox/Core is in string freeze, see https://wiki.mozilla.org/Platform/2008-09-23#Notices_.2F_Schedule

The Thunderbird string freeze does not apply to toolkit (otherwise we would have discussed/advertised it better).
> Actually our comments have been a bit unclear here. Firefox/Core is in string
> freeze, see https://wiki.mozilla.org/Platform/2008-09-23#Notices_.2F_Schedule
Huh, didn't know about that either :-(
These freezes should be noted on http://tinderbox.mozilla.org/Firefox/, as they used to be.
Keywords: checkin-needed
Target Milestone: mozilla1.9.1b1 → ---
Comment on attachment 339348 [details] [diff] [review]
patch with disabled keyset
[Checkin: Comment 15]

http://hg.mozilla.org/mozilla-central/rev/321490a24143
Attachment #339348 - Attachment description: patch with disabled keyset → patch with disabled keyset [Checkin: Comment 15]
Status: REOPENED → RESOLVED
Closed: 16 years ago16 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
Blocks: 1192540
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: