Closed Bug 382694 Opened 17 years ago Closed 17 years ago

Allow applications to specify notification names to growl other than the default

Categories

(Firefox :: Shell Integration, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: sdwilsh, Assigned: sdwilsh)

References

()

Details

Attachments

(1 file, 1 obsolete file)

Attached patch v1.0 (obsolete) — Splinter Review
Basically, apps like thunderbird want to be able to name their notifications for what they are (like New Message), but the currently can't register with them.

This provides the same mechanism as the growl extension uses, but without an official api (like grINotifications in the extension), they'll have to use objective-C and call it with the mozGrowlDelegate (unless some follow-up bug is filed).
Attachment #266812 - Flags: review?(mano)
Attachment #266812 - Flags: review?(cbarrett)
Assignee: mscott → sdwilsh
Comment on attachment 266812 [details] [diff] [review]
v1.0

Why is informController not InformController? 

What if someone wants to add a notification, but not have it enabled? Tough?

What's all this look like on Windows and/or Linux.
(In reply to comment #1)
> Why is informController not InformController?
No reason really; I can change that

> What if someone wants to add a notification, but not have it enabled? Tough?
void addNotification(in AString aName, in boolean aEnabled);
You specify false for aEnabled ;)


> What's all this look like on Windows and/or Linux.
It isn't built for windows - cocoa widgets only.
(In reply to comment #2)
> > What if someone wants to add a notification, but not have it enabled? Tough?
> void addNotification(in AString aName, in boolean aEnabled);
> You specify false for aEnabled ;)

Ah, I missed that. It's still early ;)

> > What's all this look like on Windows and/or Linux.
> It isn't built for windows - cocoa widgets only.

Right, but what's the API for notifications look like on those platforms? I'm guessing you just send, no registration required? I'm mostly just curious.

Yes, nsIAlertsService is implemented by us and uses no third party software.  There is also no support for named notifications.
(In reply to comment #4)
> There is also no support for named notifications.

Ahhh. Ok.
Comment on attachment 266812 [details] [diff] [review]
v1.0

r=me with changes discussed above.
Attachment #266812 - Flags: review?(cbarrett) → review+
Comment on attachment 266812 [details] [diff] [review]
v1.0

I have things to fix with this as per discussion with mano
Attachment #266812 - Flags: review?(mano)
Attached patch v2.0Splinter Review
I believe this addresses the concerns brought up by Mano
Attachment #266812 - Attachment is obsolete: true
Attachment #271562 - Flags: review?(mano)
Comment on attachment 271562 [details] [diff] [review]
v2.0

mpa=mano assuming this still has cbarrett's +.
Attachment #271562 - Flags: review?(mano) → review+
Cocoa stuff didn't change, so I don't see why not.
Checking in toolkit/components/alerts/public/Makefile.in;
new revision: 1.4; previous revision: 1.3
Checking in toolkit/components/alerts/public/nsINotificationsList.idl;
initial revision: 1.1
Checking in toolkit/components/alerts/src/mac/Makefile.in;
new revision: 1.6; previous revision: 1.5
Checking in toolkit/components/alerts/src/mac/mozGrowlDelegate.h;
new revision: 1.3; previous revision: 1.2
Checking in toolkit/components/alerts/src/mac/mozGrowlDelegate.mm;new revision: 1.7; previous revision: 1.6
Checking in toolkit/components/alerts/src/mac/nsAlertsImageLoadListener.h;
new revision: 1.6; previous revision: 1.5
Checking in toolkit/components/alerts/src/mac/nsAlertsImageLoadListener.mm;
new revision: 1.3; previous revision: 1.2
Checking in toolkit/components/alerts/src/mac/nsAlertsService.h;
new revision: 1.5; previous revision: 1.4
Checking in toolkit/components/alerts/src/mac/nsAlertsService.mm;
new revision: 1.8; previous revision: 1.7
Checking in toolkit/components/alerts/src/mac/nsNotificationsList.h;
initial revision: 1.1
Checking in toolkit/components/alerts/src/mac/nsNotificationsList.mm;
initial revision: 1.1
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Blocks: 394346
Blocks: 399895
This FIXED bug is flagged with in‑testsuite?   It would be great if assignee or someone else can clear the flag if a test is not appropriate.  And if appropriate, create a test and plus the flag to finish off the bug.
Not sure why this was done under Thunderbird, as much as I don't like moving bugs about after they are closed, this certainly belongs in toolkit... well maybe Shell integration (and the in-testsuite? flag is more likely to be picked up by the right devs).
Component: General → Shell Integration
Product: Thunderbird → Firefox
QA Contact: general → shell.integration
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: