Closed Bug 382741 Opened 15 years ago Closed 15 years ago

Make assertions non-fatal in cairo

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: roc, Assigned: roc)

Details

Attachments

(1 file)

Attached patch fixSplinter Review
No description provided.
Attachment #266849 - Flags: review?(vladimir)
Would it be possible to hook up cairo asserts to NS_ASSERTION or simliar
so that one can control it with XPCOM_DEBUG_BREAK?  That's very convenient
to break on assertions in a debugger for example.
That should be possible, but is Vlad OK with including XPCOM headers from cairo?
Either way, I think we should take this as a first step.
I checked this in.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Attachment #266849 - Flags: review?(vladimir) → review+
Flags: in-testsuite-
Roc, do you think that this patch is reasonable? I mean, cairo devs probably don't add hard assertions to cairo for the sake of having an assertion?
I wrote it so of course I think it's reasonable :-)

This fatal cairo assertion makes it hard for us to collect shutdown leak data and figure out why the assertion was firing in the first place.
You need to log in before you can comment on or make changes to this bug.