Closed
Bug 382823
Opened 18 years ago
Closed 18 years ago
Version/config bumps for Tb 2004
Categories
(Thunderbird :: Build Config, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: nthomas, Assigned: nthomas)
Details
Attachments
(5 files)
3.00 KB,
patch
|
preed
:
review+
|
Details | Diff | Splinter Review |
3.47 KB,
patch
|
preed
:
review+
|
Details | Diff | Splinter Review |
7.39 KB,
patch
|
rhelmer
:
review+
|
Details | Diff | Splinter Review |
4.99 KB,
patch
|
rhelmer
:
review+
|
Details | Diff | Splinter Review |
5.65 KB,
patch
|
rhelmer
:
review+
|
Details | Diff | Splinter Review |
Tracking bug for version and config bumps for the Thunderbird 2.0.0.4 release.
Assignee | ||
Comment 1•18 years ago
|
||
As well as bumping the versions an so on, this also syncs up the var list with the Firefox 2.0.0.4 config.
Attachment #266921 -
Flags: review?(preed)
Assignee | ||
Comment 2•18 years ago
|
||
These are manual changes, rather than something like attachment 263248 [details] [diff] [review] (converting to automated bumps). That's because I didn't fix bug 379380 yet, and would have to check in fixes after using the automation.
Attachment #266922 -
Flags: review?(preed)
Updated•18 years ago
|
Attachment #266922 -
Flags: review?(preed) → review+
Comment 3•18 years ago
|
||
Comment on attachment 266921 [details] [diff] [review]
bootstrap.cfg changes
>+pullDate = 2007-05-01
>+l10n_pullDate = 2007-05-01
Can you add a comment here that is #END_PLACEHOLDER (for my addled brain)
Also, are these the valid dates for the cut of the _RELBRANCH? It'd be nice to carry those over, but I suppose it's not required (if you can't immediately find them).
>+# Tinderbox server tree that clients should report to
>+buildTree = MozillaRelease
Have we done this for any other configs? I wouldn't say this is configurable per release... we want all the release output to go to MozillaRelease, so we should change that individually in the configs, not interpolate.
Attachment #266921 -
Flags: review?(preed) → review+
Assignee | ||
Comment 4•18 years ago
|
||
(In reply to comment #3)
> (From update of attachment 266921 [details] [diff] [review])
>
> >+pullDate = 2007-05-01
> >+l10n_pullDate = 2007-05-01
>
> Can you add a comment here that is #END_PLACEHOLDER (for my addled brain)
Added in checked in version.
> >+# Tinderbox server tree that clients should report to
> >+buildTree = MozillaRelease
>
> Have we done this for any other configs? I wouldn't say this is configurable
> per release... we want all the release output to go to MozillaRelease, so we
> should change that individually in the configs, not interpolate.
I removed this line before checkin, and will follow up with a patch that undoes this change in the other configs.
Assignee | ||
Comment 5•18 years ago
|
||
I'm aiming to get bug 379380 fixed before any RC2 comes around, and we can set up the CONFIG lines in tinder-config.pl then. Manual changes in the meantime.
Attachment #267199 -
Flags: review?(rhelmer)
Updated•18 years ago
|
Attachment #267199 -
Flags: review?(rhelmer) → review+
Assignee | ||
Comment 6•18 years ago
|
||
Scott, QA, and myself came to the conclusion that pushing rc1 out to beta users wouldn't gain much, so these are update config changes much as they used to be done. I also changed the 2.0.0.0rc1 block to 2.0.0.0 as we never had a rc2, or have a plain 2.0.0.0 as Firefox did.
The plan is to prepare these updates by Monday morning PDT.
Attachment #267728 -
Flags: review?(rhelmer)
Comment 7•18 years ago
|
||
Comment on attachment 267728 [details] [diff] [review]
patcher2 config changes
why change "2.0.0.0rc1" to "2.0.0.0"?
Looks good besides that, just curious.
Attachment #267728 -
Flags: review?(rhelmer) → review+
Assignee | ||
Comment 8•18 years ago
|
||
(In reply to comment #7)
> (From update of attachment 267728 [details] [diff] [review])
> why change "2.0.0.0rc1" to "2.0.0.0"?
>
> Looks good besides that, just curious.
To me, the rc1 suffix makes it seem like a special case where none is needed. There isn't any functional difference.
Assignee | ||
Comment 9•18 years ago
|
||
Attachment #267962 -
Flags: review?(rhelmer)
Updated•18 years ago
|
Attachment #267962 -
Flags: review?(rhelmer) → review+
Comment 10•18 years ago
|
||
(In reply to comment #3)
> >+# Tinderbox server tree that clients should report to
> >+buildTree = MozillaRelease
>
> Have we done this for any other configs? I wouldn't say this is configurable
> per release... we want all the release output to go to MozillaRelease, so we
> should change that individually in the configs, not interpolate.
>
Actually one useful thing about this is for testing.. you might want to send your test results to the MozillaTest tree.
Assignee | ||
Updated•18 years ago
|
Priority: -- → P1
Assignee | ||
Comment 11•18 years ago
|
||
Release is out the door and the version is already bumped to 2.0.0.5pre on the Mozilla 1.8 branch. All done here.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•