"ASSERTION: bad pref, min, max size" with <xul:grid>

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: jruderman, Assigned: neil)

Tracking

(Blocks 1 bug, {assertion, testcase})

Trunk
x86
macOS
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

220 bytes, application/vnd.mozilla.xul+xml
Details
993 bytes, patch
enndeakin
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review
Reporter

Description

12 years ago
Posted file testcase
###!!! ASSERTION: bad pref, min, max size: '(boxSizes->min <= boxSizes->pref && boxSizes->pref <= boxSizes->max)', file /Users/jruderman/trunk/mozilla/layout/xul/base/src/nsSprocketLayout.cpp, line 1180
Assignee

Comment 1

12 years ago
This is actually a bug in the equalsize calcualtion. The only reason the grid and text are used here is that an empty grid has a zero maximum size while text has a nonzero minimum size. Since the equalsize code doesn't bounds check the sizes it's generating the assertion ensues.
Assignee

Comment 2

12 years ago
Assignee: jag → neil
Status: NEW → ASSIGNED
Attachment #267005 - Flags: superreview?(bzbarsky)
Attachment #267005 - Flags: review?(enndeakin)

Updated

12 years ago
Attachment #267005 - Flags: review?(enndeakin) → review+
Comment on attachment 267005 [details] [diff] [review]
Proposed patch

Looks good.
Attachment #267005 - Flags: superreview?(bzbarsky) → superreview+
Assignee

Comment 4

12 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

Updated

12 years ago
Flags: in-testsuite?
Reporter

Comment 5

12 years ago
Crashtest checked in.
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.