382917 - Display script filename and line number in Stop Script dialog

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Manish Singh]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.4) Gecko/20070531 Firefox/2.0.0.3 Flock/0.8.0.99
Build Identifier: 

A while ago, I added code to Flock to display the filename and line number in the Stop Script dialog, to help aid figuring out what component of ours was throwing that, as it only seemed to happen in the field.

I think this is generally useful, especially for end users who won't have a debugger service installed, as they can figure out who to blame when that dialog pops up.

Reproducible: Always

Comment 1

[Manish Singh]

Attachment: Patch that is in Flock currently (based off Firefox 2)

Comment 2

[Manish Singh]

If there's interest, I can cook up a patch against trunk. I suspect the wording of the dialog could be changed to make it flow better, instead of putting the bare url and line at the end.

Comment 3

[Manish Singh]

Attachment: Example dialog

Comment 4

[Manish Singh]

Attachment: Display script filename and line number in Stop Script dialog

Comment 5

[Manish Singh]

Attachment: Example dialog when patch is applied to trunk

Comment 6

[Alex Vincent [:WeirdAl]]

I'm certainly interested, but it might be too late for 1.9.  Maybe ask for reviews?

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Shouldn't you use formatStringFromName rather than just getting the string and appending the message? It may be unlikely in this case, but in some locales the positioning/formatting of the added text can vary.

Comment 8

[Manish Singh]

That's a good point, I'll make that change.

Comment 9

[Manish Singh]

Attachment: Use formatStringFromName

Comment 10

[Manish Singh]

Comment on attachment 290810 [details] [diff] [review]
Use formatStringFromName

Asking for approval1.9.

This is low risk and isolated, and is quite useful for development. Plus it lets users make more targeted and useful bug reports when the dialog pops up for them.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

This needs sr+. (Though blake can sr too)

Comment 12

[Reed Loden [:reed]]

Checking in dom/locales/en-US/chrome/dom/dom.properties;
/cvsroot/mozilla/dom/locales/en-US/chrome/dom/dom.properties,v  <--  dom.properties
new revision: 1.10; previous revision: 1.9
done
Checking in dom/src/base/nsJSEnvironment.cpp;
/cvsroot/mozilla/dom/src/base/nsJSEnvironment.cpp,v  <--  nsJSEnvironment.cpp
new revision: 1.368; previous revision: 1.367
done

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007121107 Minefield/3.0b2pre; I see this nice functionality all the time when sorting our Litmus testcases (http://litmus.mozilla.org).