Closed Bug 382917 Opened 15 years ago Closed 14 years ago

Display script filename and line number in Stop Script dialog

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla1.9beta2

People

(Reporter: mozbugs, Assigned: mozbugs)

Details

Attachments

(2 files, 3 obsolete files)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.4) Gecko/20070531 Firefox/2.0.0.3 Flock/0.8.0.99
Build Identifier: 

A while ago, I added code to Flock to display the filename and line number in the Stop Script dialog, to help aid figuring out what component of ours was throwing that, as it only seemed to happen in the field.

I think this is generally useful, especially for end users who won't have a debugger service installed, as they can figure out who to blame when that dialog pops up.

Reproducible: Always
If there's interest, I can cook up a patch against trunk. I suspect the wording of the dialog could be changed to make it flow better, instead of putting the bare url and line at the end.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached image Example dialog (obsolete) —
Assignee: nobody → manish
Status: NEW → ASSIGNED
Attachment #266976 - Attachment is obsolete: true
Attachment #267383 - Attachment is obsolete: true
I'm certainly interested, but it might be too late for 1.9.  Maybe ask for reviews?
Attachment #290801 - Flags: review?(mrbkap)
Attachment #290801 - Flags: review?(mrbkap) → review+
Shouldn't you use formatStringFromName rather than just getting the string and appending the message? It may be unlikely in this case, but in some locales the positioning/formatting of the added text can vary.
That's a good point, I'll make that change.
Attachment #290801 - Attachment is obsolete: true
Attachment #290810 - Flags: review?(mrbkap)
Attachment #290810 - Flags: review?(mrbkap) → review+
Comment on attachment 290810 [details] [diff] [review]
Use formatStringFromName

Asking for approval1.9.

This is low risk and isolated, and is quite useful for development. Plus it lets users make more targeted and useful bug reports when the dialog pops up for them.
Attachment #290810 - Flags: approval1.9?
This needs sr+. (Though blake can sr too)
Attachment #290810 - Flags: superreview?(mrbkap)
Attachment #290810 - Flags: superreview?(mrbkap) → superreview+
Whiteboard: [has patch][has review][has sr][needs approval]
Attachment #290810 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in dom/locales/en-US/chrome/dom/dom.properties;
/cvsroot/mozilla/dom/locales/en-US/chrome/dom/dom.properties,v  <--  dom.properties
new revision: 1.10; previous revision: 1.9
done
Checking in dom/src/base/nsJSEnvironment.cpp;
/cvsroot/mozilla/dom/src/base/nsJSEnvironment.cpp,v  <--  nsJSEnvironment.cpp
new revision: 1.368; previous revision: 1.367
done
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [has patch][has review][has sr][needs approval]
Target Milestone: --- → mozilla1.9 M10
Version: unspecified → Trunk
Verified FIXED using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007121107 Minefield/3.0b2pre; I see this nice functionality all the time when sorting our Litmus testcases (http://litmus.mozilla.org).
Status: RESOLVED → VERIFIED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.