382984 - Win32: Minimize Window - Wrong Parameter for ShowWindow

Status: RESOLVED INCOMPLETE

(Core :: Widget: Win32, defect)

Description

[grischka]

User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3

On Win32: 

In at least two locations the paramenter for ShowWindow is SW_SHOWMINIMIZED (2) instead of SW_MININIZE as it should. This actually activates the application when one presses the minimize button and causes bad interaction with other applications and sometimes wrong display state of the taskbutton in the taskbar. Sometimes it is not possible also to restore Firefox from miminized on the first click.

On another note there seems to be a bug (which I dont know how it happens) where changing the theme in the display properties or changing the icon size causes Firefox to restore from minimized state spontaneously. 

Both bugs exist at least since 0.8 (and are probably somewhere in the Windows GUI OS - specific code). Sorry, I dont have the source, but I could use a hex editor to fix the first bug for me.


Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Rob Arnold [:robarnold]]

Can anyone confirm the minimize bug on 2k/XP/Vista? (the restore at theme change is known and should be a separate bug)

Comment 2

[Jim Mathies [:jimm]]

This is due to trim_on_minimize code.

Comment 3

[Phoenix]

Is this still reproducible with current Firefox versions?

Comment 4

[u279076]

Resolving this bug INCOMPLETE. Please reopen if this is reproducible in the latest Firefox Nightly.