Closed
Bug 383016
Opened 18 years ago
Closed 18 years ago
Omnibus ad-blocking bug for June
Categories
(Camino Graveyard :: Annoyance Blocking, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alqahira, Assigned: alqahira)
Details
(Keywords: fixed1.8.0.13, fixed1.8.1.5, Whiteboard: [camino-1.5.1])
Attachments
(2 files)
5.97 KB,
text/plain
|
Details | |
3.67 KB,
patch
|
sfraser_bugs
:
superreview+
|
Details | Diff | Splinter Review |
![]() |
||
Comment 1•18 years ago
|
||
Maybe something need to be done for this:
http://www.apple.com/iphone/ads/
source:
<a href="/iphone/ads/ad3/"><img src="http://images.apple.com/iphone/ads/
----------------^-----------------------------------------------^
blocked by img[src*="/ads/"],
@-moz-document domain(apple.com) {
img[src*="/ads/"] {display: inline !important }
}
(yeah, I know what you think. Bad apples in the basket)
Assignee | ||
Comment 2•18 years ago
|
||
On http://www.versiontracker.com/dyn/moreinfo/macosx/14326
<div class="prodPageGoogleAd">
Assignee | ||
Comment 3•18 years ago
|
||
Really ugly ads on http://www.technorati.com/search/http://www.ardisson.org/afkar/?partner=wordpress
# div id="ad" class="cosmos module"
# div class="doubleclick skyscraper"
# img src http://cdn.euroclick.com/contents/26767/efg_gasyear_gas_vistor_annoy_bluetop_160x600_5sec.gif
Assignee | ||
Comment 4•18 years ago
|
||
On http://osx.iusethis.com/
# div class="adbanner"
# img src : http://show.onenetworkdirect.net/42/92548/8410
Assignee | ||
Comment 5•18 years ago
|
||
Someone on irc was fighting http://flashback.info/
# div class="fb_adsys_wrapper_Leaderboard"
# div class="fb_adsys_container_Leaderboard"
# div class="fb_adsys_wrapper_LargeRectangle"
# div class="fb_adsys_container_LargeRectangle"
Comment 6•18 years ago
|
||
I'm seeing *lots* of ads on MySpace as of late. All of the similar:
<div id="ad160x600">
<div id="tkn_skyscraper"><iframe style="position: relative; z-index: 10000;" marginwidth="0" marginheight="0" hspace="0" vspace="0" src="http://deSK.opt.fimserve.com/adopt/?l=14000014&pos=skyscraper&r=h&rnd=746413640&fid=1742749" frameborder="0" height="600" scrolling="no" width="160"></iframe>
</div>
</div>
That fimserve.com one seems to be popular for some reason.
Comment 7•18 years ago
|
||
Don't have time to reduce this, so attaching a nice chunk of code. These are Google text ads I saw on MySpace.
![]() |
||
Comment 8•18 years ago
|
||
(In reply to comment #1)
… or maybe not - Apple changed their iPhone site: the given url now redirect to one movie, the starting point is http://www.apple.com/iphone/gallery/ with images loaded from an 'images' folder.
Assignee | ||
Comment 9•18 years ago
|
||
On http://www.imdb.com/name/nm2172860/
<iframe title="" style="outline-color: invert; outline-style: none; outline-width: medium;" name="GoogleAd" src="http://i.imdb.com/images/3pads/google/google-afc.html?channel=n-channel" marginheight="0" marginwidth="0" align="top" frameborder="0" height="240" scrolling="no" width="500"></iframe>
Assignee | ||
Comment 10•18 years ago
|
||
This is June's patch. A couple of these have change/disappeared since they were commented (e.g., on VT, the ad is now <div class="context-ad">), but this blocks everything as far as I am able to test.
I kept philippe's Apple rule since I can still see the images being blocked as I navigate through the iPhone TV ads. (I also added philippe to the contributors since he's contributed a number of rules we've included wholesale.)
Attachment #271485 -
Flags: superreview?(sfraser_bugs)
Updated•18 years ago
|
Attachment #271485 -
Flags: superreview?(sfraser_bugs) → superreview+
Assignee | ||
Updated•18 years ago
|
Whiteboard: [needs checkin]
Assignee | ||
Comment 11•18 years ago
|
||
Er, depending on how long this has been baking when we start 1.5.1 work, we might want to take it there.
Flags: camino1.5.1?
Comment 12•18 years ago
|
||
Landed on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1.5
Resolution: --- → FIXED
Whiteboard: [needs checkin]
Updated•18 years ago
|
Flags: camino1.5.1?
Updated•18 years ago
|
Flags: camino1.5.1?
Assignee | ||
Comment 13•18 years ago
|
||
Approving for 1.5.1 per irc, and nominating for 1.0.6, too.
Flags: camino1.5.1?
Flags: camino1.5.1+
Flags: camino1.0.6?
Comment 14•18 years ago
|
||
Landed on CAMINO_1_5_BRANCH.
Comment 15•18 years ago
|
||
Sync'd up through this patch on MOZILLA_1_8_0.
Flags: camino1.0.6? → camino1.0.6+
Assignee | ||
Updated•18 years ago
|
Keywords: fixed1.8.0.12
Whiteboard: [camino-1.5.1]
Assignee | ||
Comment 16•18 years ago
|
||
I'm not doing a very good job with my keywords tonight; sorry :(
Keywords: fixed1.8.0.12 → fixed1.8.0.13
You need to log in
before you can comment on or make changes to this bug.
Description
•