Omnibus ad-blocking bug for June



12 years ago
12 years ago


(Reporter: alqahira, Assigned: alqahira)


({fixed1.8.0.13, fixed1.8.1.5})

Mac OS X
fixed1.8.0.13, fixed1.8.1.5
Bug Flags:
camino1.0.6 +
camino1.5.1 +


(Whiteboard: [camino-1.5.1])


(2 attachments)

Maybe something need to be done for this:
<a href="/iphone/ads/ad3/"><img src="

blocked by img[src*="/ads/"],

@-moz-document domain( {
img[src*="/ads/"] {display: inline !important }

(yeah, I know what you think. Bad apples in the basket)
Someone on irc was fighting

# div class="fb_adsys_wrapper_Leaderboard"
# div class="fb_adsys_container_Leaderboard"

# div class="fb_adsys_wrapper_LargeRectangle"
# div class="fb_adsys_container_LargeRectangle"
I'm seeing *lots* of ads on MySpace as of late. All of the similar:

<div id="ad160x600">
<div id="tkn_skyscraper"><iframe style="position: relative; z-index: 10000;" marginwidth="0" marginheight="0" hspace="0" vspace="0" src=";pos=skyscraper&amp;r=h&amp;rnd=746413640&amp;fid=1742749" frameborder="0" height="600" scrolling="no" width="160"></iframe>

That one seems to be popular for some reason.
Created attachment 269356 [details]
MySpace Google Ads

Don't have time to reduce this, so attaching a nice chunk of code. These are Google text ads I saw on MySpace.
(In reply to comment #1)

… or maybe not - Apple changed their iPhone site: the given url now redirect to one movie, the starting point is with images loaded from an 'images' folder.

<iframe title="" style="outline-color: invert; outline-style: none; outline-width: medium;" name="GoogleAd" src="" marginheight="0" marginwidth="0" align="top" frameborder="0" height="240" scrolling="no" width="500"></iframe>
Created attachment 271485 [details] [diff] [review]
June Omnibus patch

This is June's patch.  A couple of these have change/disappeared since they were commented (e.g., on VT, the ad is now <div class="context-ad">), but this blocks everything as far as I am able to test.  

I kept philippe's Apple rule since I can still see the images being blocked as I navigate through the iPhone TV ads.  (I also added philippe to the contributors since he's contributed a number of rules we've included wholesale.)
Attachment #271485 - Flags: superreview?(sfraser_bugs)


12 years ago
Attachment #271485 - Flags: superreview?(sfraser_bugs) → superreview+
Whiteboard: [needs checkin]
Er, depending on how long this has been baking when we start 1.5.1 work, we might want to take it there.
Flags: camino1.5.1?

Comment 12

12 years ago
Landed on trunk and MOZILLA_1_8_BRANCH.
Last Resolved: 12 years ago
Keywords: fixed1.8.1.5
Resolution: --- → FIXED
Whiteboard: [needs checkin]
Flags: camino1.5.1?
Flags: camino1.5.1?
Approving for 1.5.1 per irc, and nominating for 1.0.6, too.
Flags: camino1.5.1?
Flags: camino1.5.1+
Flags: camino1.0.6?

Comment 14

12 years ago
Landed on CAMINO_1_5_BRANCH.

Comment 15

12 years ago
Sync'd up through this patch on MOZILLA_1_8_0.
Flags: camino1.0.6? → camino1.0.6+
Keywords: fixed1.8.0.12
Whiteboard: [camino-1.5.1]
I'm not doing a very good job with my keywords tonight; sorry :(
Keywords: fixed1.8.0.12 → fixed1.8.0.13
You need to log in before you can comment on or make changes to this bug.