383125 - Use breakpad for SeaMonkey trunk

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Robert Kaiser]

As we finally have new OSS crash reporting technology, we should use it ;-)

SeaMonkey would love to be one of the first testers and adopters of breakpad, esp. as there are problems with Talkback for community builds anyways (see bug 373373) and we had no crash reporting on mac for an even longer time (bug 328854) - so we'd re-gain crash reporting again with that, which sounds like a good idea for trunk :)

Comment 1

[Robert Kaiser]

Also see bug 379396 which is basically the same for Thunderbird

Comment 2

[Robert Kaiser]

OK, it looks like ther only step we still need to go is enabling breakpad and disabling/removing Talkback ;-)

Comment 3

[Robert Kaiser]

Attachment: Enable breakpad, disable Talkback

This enables breakpad for SeaMonkey and removes building Talkback from the two tinderboxen that build it currently.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 271527 [details] [diff] [review]
Enable breakpad, disable Talkback

You know, I forgot to comment, but you should have
#if MOZILLA_OFFICIAL
Enabled=1
#endif so we don't wind up gettting reports from random self builds.

Comment 5

[Robert Kaiser]

Checked in with the ifdef from comment #4

Comment 6

[Adam Guthrie]

You should probably set the MOZ_CRASHREPORTER_DISABLE env. var. on the tinderboxes themselves until bug 379290 gets fixed, otherwise the crash reporter dialog will come up when it crashes and cause problems.

Comment 7

[Robert Kaiser]

(In reply to comment #6)
> You should probably set the MOZ_CRASHREPORTER_DISABLE env. var. on the
> tinderboxes themselves until bug 379290 gets fixed, otherwise the crash
> reporter dialog will come up when it crashes and cause problems.

Actually, what we really want is MOZ_CRASHREPORTER_NO_REPORT, which I learned by breakpad unit tests failing with the other one - but that's done now :)