Tinderbox: only call 'make deliver' on Windows

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
11 years ago
4 years ago

People

(Reporter: coop, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
This has been an error _forever_. 

This target only exists on Windows, so we should use the existing platform determination code to make sure it only gets run on win32.

Patch forthcoming.
(Reporter)

Updated

11 years ago
Status: NEW → ASSIGNED

Comment 1

11 years ago
Yuck. Why don't we just make "deliver" a no-op on non-Windows platforms?
You could just put an else right here:
http://mxr.mozilla.org/mozilla/source/Makefile.in#203

and put in an empty deliver target.
(Reporter)

Comment 3

11 years ago
Adding the code to tinderbox means I only have to do it in one place, rather than on every branch. It will go away when Talkback is retired anyway.
(Reporter)

Comment 4

11 years ago
Created attachment 267173 [details] [diff] [review]
Only call 'make deliver' target on Windows
Attachment #267173 - Flags: review?(nrthomas)
Comment on attachment 267173 [details] [diff] [review]
Only call 'make deliver' target on Windows

r=cf, looks good.
Attachment #267173 - Flags: review?(nrthomas) → review+
(Reporter)

Comment 6

11 years ago
Checking in post-mozilla-rel.pl;
/cvsroot/mozilla/tools/tinderbox/post-mozilla-rel.pl,v  <--  post-mozilla-rel.pl
new revision: 1.119; previous revision: 1.118
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.