Add new reportMatch function in shell.js

RESOLVED FIXED

Status

Rhino
Core
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Norris Boyd, Assigned: Norris Boyd)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
I've added a new analog to reportCompare that instead takes an expected regular expression to match the expected value to. This helps Rhino since a number of the tests are written to expect exact matches on error messages. The patch also contains changes to several tests to use reportMatch for these types of cases.
(Assignee)

Comment 1

11 years ago
Created attachment 267195 [details] [diff] [review]
Patch for reportMatch
Comment on attachment 267195 [details] [diff] [review]
Patch for reportMatch

works for me, but drop the rhino-n.tests stuff. That has moved anyway right?
Attachment #267195 - Flags: review+
(Assignee)

Comment 3

11 years ago
Yes, thanks, the rhino-n.tests diff was not intended for this bug.

Do you want me to check in?
(Assignee)

Comment 4

11 years ago
Committed patch (excepting changes to rhino-n.tests).
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Updated

11 years ago
Version: 1.6R5 → 1.6R6
You need to log in before you can comment on or make changes to this bug.